Channel insert/updates now strip off leading/trailing whitespace in callsign and name

[Jerry Rubinow <jerrymr@…>]

Modified places where channels are inserted or updated in the database to call QString::trimmed() on channel callsign and name. This prevents some potential mismatches when guide information is merged (i.e. one input has a channel with callsign "WABC" and tuner 2 has the same channel but the callsign is "WABC ", so they show up separately in the guide).

The patch modifies mfdb/channeldata.cpp, libmythtv/channelutil.cpp, libmythtv/datadirect.cpp, and libmythtv/tv_rec.cpp. This is my first patch submission, let me know if I made any mistakes in protocol. And please direct me to any other places that need modification which I missed. Finally, I verified successful compilation, but I'm unable to test.

[Jerry Rubinow <jerrymr@…>]

patch for files in libmythtv

[Jerry Rubinow <jerrymr@…>]

patch for files in mythfilldatabase

[Jerry Rubinow <jerrymr@…>]

Now I'm able to test, and mythtv-setup doesn't seem to use the update method in channelutil.cpp. I'll update the ticket when I have something usable, but don't waste time trying to use it in the meantime.

[Jerry Rubinow <jerrymr@…>]

Here's is an updated and tested patch which trims callsign, channel number, and channel name in libmythtv/channelsettings.cpp, libmythtv/channelutil.cpp, libmythtv/tv_rec.cpp, and in mythweb in modules/tv/set_channels.php. I've verified the changes work correctly in the mythtv-setup channel editor, when using 'e' in the program guide, and in mythweb.

It seems like there's an extra place in the code that modifies the channel table which doesn't have a corresponding channel editor I was able to find. Also, I found two more places in the code, in mythfilldatabase and in libmythtv/datadirect.cpp, which update the channel table. I wasn't sure if these places should trim as well. They are currently unmodified.

These two patches (one for master, one for mythweb) supplant the earlier attachments.

[Karl Dietz <dekarl@…>]

In d847d55f18315175d6f8b46f821e936d459ebd9d/mythtv:

avoid \0 characters in ATSC strings, also simplify them

Refs #10046
Refs #12612

[Karl Dietz <dekarl@…>]

In fdc94ef2465f0b596bd785dd9d39029c811f1ec6/mythtv:

update unit test for ATSC channel names after fixes

Refs #10046
Refs #12612

[Karl Dietz <dekarl@…>]

In aba4858bd6b3f9abe9ba19adf8c833ba37150d61/mythtv:

avoid \0 characters in ATSC strings, also simplify them

Refs #10046
Refs #12612

(cherry picked from commit d847d55f18315175d6f8b46f821e936d459ebd9d)

[Stuart Auchterlonie]

We have moved all bug tracking to github [1]

If you continue to have this issue, please open a new issue at github, referencing this ticket.

[1] - ​https://github.com/MythTV/mythtv/issues