Ticket #10199 (closed Bug Report - General: fixed)
Opened 18 months ago
Last modified 15 months ago
nuvexport encoding broken by commit 7e1a770
| Reported by: | zeloise@… | Owned by: | beirdo |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.25 |
| Component: | Apps - Nuvexport | Version: | Unspecified |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
Hello,
Commit 7e1a770 and f3207c4 broke nuvexport. The encoded video file result have a very fast display audio and video (17mn instead of 52mn) Removing those commit for transcode.cpp only solve the problem.
Thanks in advance for your help zeloise
Attachments
Change History
comment:1 Changed 17 months ago by beirdo
- Owner set to beirdo
- Status changed from new to assigned
- Component changed from MythTV - Mythtranscode to Apps - Nuvexport
comment:2 Changed 17 months ago by beirdo
First off, what encoding parameters are you using?
comment:3 Changed 17 months ago by beirdo
Sorry, and what format is the original recording?
comment:4 Changed 17 months ago by zeloise@…
Hello Beirdo
my job is : /usr/bin/nuvexport-xvid --nice 19 --input="%FILE%" and the init file is attached (nuvexportrc)
I hope this helps
zeloise
comment:5 Changed 15 months ago by zeloise@…
Hello Beirdo,
In order to helps the debbug you will find 2 avi files converted via nuvexport from the same BBC program recorded (by dvb-Sat) with (Bad) or without (Good) the commit 7e1a770 and f3207c4 for transcode.cpp only:
- Click.Transcode.20120225.c2a0b85z.Bad.avi (http://dl.free.fr/kypkvqIqQ)
- Click.Transcode.20120225.c2a0b85z.Good.avi (http://dl.free.fr/kfGpZYiDm)
I hope this helps zeloise
comment:6 Changed 15 months ago by Github
- Status changed from assigned to closed
- Resolution set to fixed
- Milestone changed from unknown to 0.25
Totally rework the AudioReencodeBuffer? part in transcode
The fifo mode of transcode got completely messed up with the advent of HLS mode for mythtranscode. The core issue was that the video and audio were being consumed in different ways, and were no longer well synced. The video was being queued, and the audio just accumulated until the each video frame was dealt with. This caused a majority of the video frames to be dropped to attempt to resync to the audio, and unnecessarily.
I changed it to actually queue up the audio buffers, and allow the consumer to pull from that list up until a given timecode, keeping the audio and video in sync enough for the existing resync code to deal with it.
This has so far been tested in fifo mode only, and with no cutpoints.
Fixes #10199, may affect others as well.
This may break HLS if audio frame sizes differ between input and output, but this is being worked on, and should be out shortly as well.
Branch: master Changeset: 0fe6e143faf4a987ec97203840d991de5578dbf2
comment:7 Changed 15 months ago by Github
Rework AudioReencodeBuffer? further to fix HLS audio buffering
Added back in some code to only pass full buffers (or multiples thereof) to the consuming transcoder. This should fix the potential issues with HLS transcoding with different input and output audio frame sizes.
Also redid AudioBuffer? to use a QByteArray to simplify the memory management when appending buffers.
Refs #10199
Branch: master Changeset: 7b526c4727e798fa25d7d13baa2b0f5a06107997
