Opened 12 years ago
Closed 12 years ago
Last modified 10 years ago
#10235 closed Bug Report - General (Need more Info)
Compilation album is never detected
| Reported by: | Owned by: | stuartm | |
|---|---|---|---|
| Priority: | minor | Milestone: | unknown |
| Component: | Plugin - MythMusic | Version: | 0.24.1 |
| Severity: | medium | Keywords: | mythmusic compilation various artists |
| Cc: | Ticket locked: | no |
Description
Hi,
due to a bug in metaioid3's function "*MetaIOID3::read" compilation albums are never detected.
In line 310 musicbrainz ALBUMARTIST_UUID is stored in "TStringToQString(musicbrainz->fieldList().back()))" and not in "TStringToQString(musicbrainz->fieldList().front()))" as in the source.
The correct paragraph is below:
if (musicbrainz)
{
// If the MusicBrainz ID is the special "Various Artists" ID
// then compilation is TRUE
if (!compilation && !musicbrainz->fieldList().isEmpty())
compilation = (MYTH_MUSICBRAINZ_ALBUMARTIST_UUID
== TStringToQString(musicbrainz->fieldList().back()));
}
This patch is tested and works.
Christian
Change History (7)
comment:1 Changed 12 years ago by
comment:2 Changed 12 years ago by
| Owner: | changed from paulh to stuartm |
|---|---|
| Status: | new → assigned |
comment:3 Changed 12 years ago by
| Status: | assigned → infoneeded |
|---|
comment:4 follow-up: 5 Changed 12 years ago by
| Resolution: | → Need more Info |
|---|---|
| Status: | infoneeded → closed |
Note: See
TracTickets for help on using
tickets.
There should be only one string field in that tag, hence front() should work. Can you dump all the fields and see what's being inserted before MYTH_MUSICBRAINZ_ALBUMARTIST_UUID?
Which application was the tagging done in? Mythmusic/Picard/Other??
If some apps are sticking other text in the field it could appear after the UUID as well in which back() would break it for others. We could iterate over all fields checking each but if it's mythmusic inserting the bad data then we should fix that instead.