Opened 12 years ago
Closed 11 years ago
#10301 closed Patch - Bug Fix (Fixed)
[PATCH] mythtranscode: --fifoinfo reports aspect ratio of first uncut frame
Reported by: | Owned by: | beirdo | |
---|---|---|---|
Priority: | minor | Milestone: | 0.25 |
Component: | MythTV - Mythtranscode | Version: | Master Head |
Severity: | medium | Keywords: | fifoinfo |
Cc: | Ticket locked: | no |
Description
This fixes a problem using the --fifoinfo option to report the format of a recording. When using a cutlist the first few frames may be cut and the format of the first uncut frame may be different from the first physical frame.
This fixes a problem when using nuvexport etc if the recording starts in widescreen e.g. for adverts but switches to 4:3 for the feature.
Attachments (1)
Change History (7)
Changed 12 years ago by
Attachment: | 0001-mythtranscode-fifoinfo-reports-aspect-ratio-of-first.patch added |
---|
comment:1 Changed 12 years ago by
Owner: | set to beirdo |
---|---|
Status: | new → assigned |
comment:2 Changed 12 years ago by
Milestone: | unknown → 0.25 |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
comment:3 Changed 12 years ago by
I don't believe this will affect nuvexport in any way as we do not use --fifoinfo. However, the patch seems sound, and doesn't break anything in my testing.
comment:4 Changed 11 years ago by
I believe this fix actually causes problems, as it seems to use the actual frame size assuming square pixels.
For instance, I have many DVB recordings at 704x576 with a DAR of 16:9, so that the output frame size is 1024x568. When mythtranscode -fifoinfo is run I get FifoVideoAspectRatio 1.77778
as expected, but adding -honorcutlist now gives me FifoVideoAspectRatio 1.22222
.
I am afraid I am not sure what the correct call is (having never read any of the source), but I am assuming it is the following line of the patch which needs changing to get the output frame size, rather that the source size:
video_aspect = player->GetVideoAspect();
comment:5 Changed 11 years ago by
Resolution: | fixed |
---|---|
Status: | closed → new |
mythtranscode: --fifoinfo reports aspect ratio of first uncut frame
This fixes a problem using the --fifoinfo option to report the format of a recording. When using a cutlist the first few frames may be cut and the format of the first uncut frame may be different from the first physical frame.
This fixes a problem when using nuvexport etc if the recording starts in widescreen e.g. for adverts but switches to 4:3 for the feature.
Fixes #10301
Signed-off-by: Lawrence Rust <lvr@…> Signed-off-by: Gavin Hurlbut <ghurlbut@…>