Metadata Options doesn't always fill out TVDB number

[kenni]

The Metadata Options for a recording rule doesn't populate the TMDB/TVDB number when multiple results from thetvdb are found and one of these are selected, while Season/Episode? is set to 0/0.

Tested on master from today (v0.25pre-4682-gc2a0b85) with Arclight.

An illustrated example:

There's a recording rule for "X-Files" and we click on "Metadata Options":
​http://postimage.org/image/4gnwjxg8z/

MythTV performs a search and comes up with four results, all from thetvdb.com:
​http://postimage.org/image/rlj5el2fh/

The first one is the right one, so we select it. The results are now briefly removed from the screen (for about 2 seconds) while the screen from behind the results is shown:
​http://postimage.org/image/tsyezhi83/

The TMDB/TVDB # field does NOT get populated now, instead the results are shown again:
​http://postimage.org/image/rlj5el2fh/

Selecting the same item again, results in the same loop. This behavior continues infinitely.

If you instead exit out of the presented results and set Season/Episode? to 1/1 followed by a click on "Perform Query", the same 4 results will show up - but this time the TVDB number WILL get populated correctly when the first item is selected:
​http://postimage.org/image/h0jyaf2bn/

[lomion@…]

The MetadataFactory? is guessing wether you looking for a recording or a movie by checking for Subtitle and Season/Episode?. If you have no Season/Episode? set and no Subtitle from EIT it assumes its a movie. The lookup type is not updated based on the grapper you get your result from ... this behaviour is fixed with the attached patch.

[robertm]

This patch will beak the metadata classes in a number of their other uses. I think there is a less intrusive way to solve this which I will try to look at before the release.

[lomion@…]

This time I didn't change the metadata classes but changed the MetadataOptions? so that they just use the selected query results instead of doing another lookup. Worked for me ... hope it did not break anything else ...

[Michael T. Dean <mdean@…>]

In ea5aa87578e857e205291b0d95a42ceef70f6c21/mythtv:

Fix metadata options editor for multiple results.

Thanks to lomion for the patch (and apologies for the delay in applying
it).

Refs #10383

[Michael T. Dean <mdean@…>]

In 682e6f514bf7a69338c29959dbd746d9cea590ab/mythtv:

Fix metadata options editor for multiple results.

Thanks to lomion for the patch (and apologies for the delay in applying
it).

Fixes #10383
(cherry picked from commit ea5aa87578e857e205291b0d95a42ceef70f6c21)