Ticket #10466 (closed Bug Report - General: fixed)
Opened 14 months ago
Last modified 14 months ago
VDA playback makes mythfrontend hang with some videos
| Reported by: | jyavenard | Owned by: | jyavenard |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.25 |
| Component: | MythTV - General | Version: | Unspecified |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
som BBC HD samples tried completely freeze mythfrontend.
Attachments
Change History
comment:1 Changed 14 months ago by jyavenard
- Owner set to jyavenard
- Status changed from new to assigned
comment:2 Changed 14 months ago by Github
- Status changed from assigned to closed
- Resolution set to fixed
- Milestone changed from unknown to 0.25
Fix VDA playback for some videos.
This fix allows playing BBC videos. Apple Video Decode Acceleration framework doesn't handle interlaced h264 properly. So add a quick test to check if video is interlaced or not.
While our original VDA code was heavily based on XBMC implementation, it introduced some errors ; there were some minor leaks and some necessary broken h264 encoding workarounds weren't implemented (AVD just hang on those)
Additionally, XBMC has fixed bugs since and the fixes never made it to mythtv.
Tracking what changed where was too time consuming, so shamelessly remove our customisation and re-use XBMC initialisation code as-is. Additionally, we were using a non-official ffmpeg call (ff_find_start_code) which has been renamed and moved since; so the previous code would have been broken during the next ffmpeg resync.
FFmpeg master now supports VDA decoding, but their code doesn't handle any of the borderline scenarios handled here. Making it pretty much useless for the time being
Fixes #10466
Branch: master Changeset: 2c08a7d1788b4a8183a70c288be0cec46a3f36d0
