Ticket #10536 (closed Bug Report - General: Fixed)
Opened 14 months ago
Last modified 14 months ago
Correct saving of the DTSHDPassThru state
| Reported by: | Gary Buhrmaster <gary.buhrmaster@…> | Owned by: | jyavenard |
|---|---|---|---|
| Priority: | minor | Milestone: | unknown |
| Component: | MythTV - Audio Output | Version: | Unspecified |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
In setupwizard_audio.cpp gcc produces the warning: setupwizard_audio.cpp:237:9: warning: variable ‘dtshdState’ set but not used [-W unused-but-set-variable]
While many of these are set but not used messages are essentially uninteresting, in this case the variable appears to have been intended to be used in the next line to save the state, and instead a different variable was used in the saving of the setting.
From a cursory examination, it appears that during the copy/paste/edit of the code fragments, this particular edit was overlooked.
Patch attached.
Attachments
Change History
Changed 14 months ago by Gary Buhrmaster <gary.buhrmaster@…>
- Attachment setupwizard_audio_cpp.patch added
comment:1 Changed 14 months ago by jyavenard
I'm very keen on completely dropping the audio part of the "wizard"
it just doesn't work like it should, it adds nothing over the existing audio setup ; quite the opposite
comment:2 Changed 14 months ago by robertm
- Status changed from new to closed
- Resolution set to Fixed
fixed in 711386d
