Opened 12 years ago
Closed 12 years ago
#10536 closed Bug Report - General (Fixed)
Correct saving of the DTSHDPassThru state
Reported by: | Owned by: | JYA | |
---|---|---|---|
Priority: | minor | Milestone: | unknown |
Component: | MythTV - Audio Output | Version: | Unspecified |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
In setupwizard_audio.cpp gcc produces the warning: setupwizard_audio.cpp:237:9: warning: variable ‘dtshdState’ set but not used [-W unused-but-set-variable]
While many of these are set but not used messages are essentially uninteresting, in this case the variable appears to have been intended to be used in the next line to save the state, and instead a different variable was used in the saving of the setting.
From a cursory examination, it appears that during the copy/paste/edit of the code fragments, this particular edit was overlooked.
Patch attached.
Attachments (1)
Change History (3)
Changed 12 years ago by
Attachment: | setupwizard_audio_cpp.patch added |
---|
comment:1 Changed 12 years ago by
Note: See
TracTickets for help on using
tickets.
I'm very keen on completely dropping the audio part of the "wizard"
it just doesn't work like it should, it adds nothing over the existing audio setup ; quite the opposite