Screen setup wizard bottom right arrow not visible

[Yves Cayer <ycayer@…>]

When entering the screen setup wizard for the first time, the bottom right arrow is not visible. It is off screen to the right. While it can be moved up and left and positioned to the screen dimensions, this results in the wrong screen size.

If the screen setup wizard is entered a second time, the bottom right arrow is visible.

The reason for this behaviour is because the image for the arrows get loaded in a background thread and are not ready when the dimensions are extracted, resulting is 0,0 size. This effectively positions the bottom right arrow with its top left corned as the origin instead of its bottom right, resulting in an error in x and y equivalent to the size of the arrow image.

I'm attaching a patch with what I think is a good workaround. When the bottom right arrow is selected, it checks for a zero size arrow and re-initializes it. On my systems, the arrow was always positioned correctly with the patch applied.

Perhaps there's a way to have the images load in the current thread, but I haven't found anything yet.

[Raymond Wagner]

The arrows have been removed, in favor of a re-sizable copy of the theme preview image, so this fix is no longer applicable.

See 690f333e59205de8b582992a894d63695676b41e