Ticket #10672 (accepted Developer Task)
Opened 13 months ago
Last modified 8 months ago
Maddening Video Metadata Save/Exit Behavior [patch]
| Reported by: | adiemus <mythtv@…> | Owned by: | stuartm |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.27 |
| Component: | MythTV - Video Library | Version: | 0.25-fixes |
| Severity: | low | Keywords: | metadata editor return save exit root |
| Cc: | Ticket locked: | no |
Description
Having recently upgraded from 0.21-fixes to 0.25-fixes, one of the things I was most excited about was getting useful metadata into my videos. However, I quickly found myself to the point of near rage at the metadata edit dialog's behavior of returning to the root of the video list when done editing a file, rather than returning to the file just edited. (Making editing multiple files take a *painfully* long time, even with a keyboard)
Attached is a patch that (mis-)uses the "save and restore video selection" logic to make save/exit-ing from the metadata edit dialog return to the video just edited.
I've tested it locally in list/browser/gallery modes, and they all seem to work. However, I'm very unfamiliar with myth's codebase, and I'm quite sure this need a good looking over. (I've noticed, for example, that in browser/gallery mode the file counts when returning from edit are wrong, until you move to a new video, though you do end up back on the correct video. I mostly use the list view and am fairly unfamiliar with the browser/gallery views so I didn't look into this further)
Hope this is at least marginally useful.
Attachments
Change History
Changed 13 months ago by adiemus <mythtv@…>
- Attachment mythtv-video-metadata-editor-return-behavior.patch added
Changed 12 months ago by adiemus <mythtv@…>
- Attachment mythtv-video-metadata-editor-return-behavior-update.patch added
Updated patch for the current state of 0.25-fixes
comment:1 Changed 11 months ago by beirdo
- Component changed from MythTV - General to MythTV - Video Library
comment:2 Changed 11 months ago by beirdo
- Milestone changed from 0.25.1 to unknown
Please do not set the milestone.
comment:3 Changed 11 months ago by stuartm
- Owner set to stuartm
- Status changed from new to accepted
- Milestone changed from unknown to 0.26
comment:5 Changed 8 months ago by stuartm
- Type changed from Patch - Bug Fix to Developer Task
- Milestone changed from 0.26.1 to 0.27
I think there is another, better way to do this using the update event stuff that I'm working on to fix the bookmark/watched status bug.

Patch to return to the just edited file when exiting the video metadata edit dialog