Ticket #10704 (closed Patch - Bug Fix: fixed)
Opened 13 months ago
Last modified 6 months ago
Expired programs are not being deleted with master/slave backends.
|Reported by:||Ian Dall <ian@…>||Owned by:||stuartm|
|Component:||MythTV - Housekeeper||Version:||Master Head|
When there are separate master and slave backends, recordings made on the slave are not deleted properly. They are moved to the "Deleted" recording group, but the files are not deleted and the database entries are not removed from the 'recorded' table.
Since this does not free up space, eventually all expirable programs end up in the "Deleted" group.
If the master backend is restarted the files are deleted and the database entries removed.
This appears to be introduced with commit f78f9992d754390fa42f109e5139b8eaf224d076
This appears to be because AutoExpire::SendDeleteMessages() records programs which have been moved to the "Deleted" group in deleted_set. Autoexpire::UpdateDontExpireSet() initialises dont_expire_set from deleted_set and AutoExpire::FillDBOrdered() skips programs in dont_expire_set when constructing expireList.
I can see what is wrong but it is harder to understand what is supposed to be happening and figure out the fix. This is not helped by some some variable and function names. dont_expire_set seems to be used to mean "don't delete" rather than "don't expire".
I THINK removing all references to deleted_set and initialising dont expire_set to the empty set would solve the problem.
This issue would be masked by what looks like another bug when there are no slave backends. If the recording hostname is the same as the master hostname, autoexpired programs are just deleted without first sticking them in the "Deleted' recording group.
comment:1 Changed 11 months ago by beirdo
- Milestone changed from 0.26 to unknown
comment:2 Changed 6 months ago by Jason <jason-devel-mythtv@…>
comment:3 Changed 6 months ago by Ian Dall <ian@…>
comment:4 Changed 6 months ago by davescammell@…
comment:5 Changed 6 months ago by stuartm
- Type changed from Bug Report - General to Patch - Bug Fix
comment:6 Changed 6 months ago by stuartm
- Owner set to mdean
- Status changed from new to assigned
- Component changed from MythTV - General to MythTV - Housekeeper
- Milestone changed from unknown to 0.26.1
comment:7 Changed 6 months ago by davescammell@…
comment:8 Changed 6 months ago by stuartm
- Owner changed from mdean to stuartm
- Status changed from assigned to accepted
comment:9 Changed 6 months ago by Ian Dall <ian@…>
- Status changed from accepted to closed
- Resolution set to fixed