Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#11561 closed Patch - Bug Fix (fixed)

Incorrect import of PIL in mythplugins/mytharchive/mythburn/scripts/mythburn.py

Reported by: rich0@… Owned by: Richard Freeman <rich0@…>
Priority: minor Milestone: 0.27
Component: Plugin - MythArchive Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

mythplugins/mytharchive/mythburn/scripts/mythburn.py imports PIL modules using a deprecated syntax.

Patch attached.

Attachments (1)

0001-Fix-for-deprecated-use-of-PIL-modules.patch​ (925 bytes) - added by rich0@… 11 years ago.
Correction for PIL imports

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by rich0@…

Attachment: 0001-Fix-for-deprecated-use-of-PIL-modules.patch​ added

Correction for PIL imports

comment:1 Changed 11 years ago by J.Pilk@…

Using Fedora17, MythTV Version : 0.26.0-8.fc17 (v0.26.0-149-g5f45c0b) from rpmfusion, MythTV Branch : fixes/0.26, /usr/lib64/python2.7/site-packages/PIL, I've never seen anything that suggested a problem here, but I've applied the patch and it still works.

comment:2 Changed 11 years ago by paulh

Component: MythTV - General → Plugin - MythArchive

comment:3 Changed 11 years ago by paulh

Status: new → infoneeded_new

Can you be more specific about what the error is you are trying to fix?

comment:4 in reply to:  3 Changed 11 years ago by rich0@…

Replying to paulh:

Can you be more specific about what the error is you are trying to fix?

Apparently pillow (a better-maintained somewhat drop-in replacement for PIL) requires the newer syntax. PIL itself is moving towards only supporting the PIL namespace as well: ​http://mail.python.org/pipermail/image-sig/2011-January/006650.html

Gentoo is moving towards Pillow and is generally trying to get packages remediated. It is correct that on v1.1 of PIL that the current syntax is still supported.

comment:5 Changed 11 years ago by Richard Freeman <rich0@…>

Owner: set to Richard Freeman <rich0@…>
Resolution: → fixed
Status: infoneeded_new → closed

In ea17bd1faf78c58d29cf68d3840347254988950d/mythtv:

MythArchive?: Fix for deprecated use of PIL python modules

This allows mythburn.py to work with both Python Imaging Library (PIL)
and Pillow the PIL fork.

Fixes #11561.

Signed-off-by: Paul Harrison <pharrison@…>

comment:6 Changed 11 years ago by paulh

Milestone: unknown → 0.27
Version: Unspecified → Master Head
Note: See TracTickets for help on using tickets.