Opened 8 years ago
Closed 7 years ago
Last modified 6 years ago
#12893 closed Patch - Feature (Fixed)
Add decoding H.264 CC608/708 captions
| Reported by: | Owned by: | Peter Bennett | |
|---|---|---|---|
| Priority: | minor | Milestone: | 29.0 |
| Component: | MythTV - General | Version: | Master Head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
The local cable company (Comcast) has converted more channels to H.264. These patches allow decoding of CC608/708 captions in these streams.
(NOTE: I'm not sure if the libav patch is right, but it looked like the A54 captions were only present whenever the field_poc check failed, so the code to save it wasn't getting executed. I moved that code to just before the check.)
Attachments (2)
Change History (14)
Changed 8 years ago by
| Attachment: | 0001-Changed-to-copy-A53-captions-before-field-check.patch added |
|---|
Changed 8 years ago by
| Attachment: | 0002-Added-decoding-of-A53-captions.patch added |
|---|
mythtv patch to add A53 caption decoding
comment:1 Changed 8 years ago by
Thanks Gregorio.
It would be best if you could get the ffmpeg part committed to the upstream ffmpeg project. Or is it already? If it is, we need to sync to that version.
comment:2 Changed 8 years ago by
From looking at FFmpeg git, it appears the same problem may exist in release 3.1. However, the affected code has been refactored in master and may not have the same problem.
comment:3 Changed 7 years ago by
I tested this patch with MythTV master. With this patch, Comcast x264 subtitles work perfectly. I also verified that the Comcast mpeg-2 subtitles and subtitles on videos still work.
I tested VDPAU, VAAPI and Slim. All are OK.
comment:4 Changed 7 years ago by
| Owner: | set to Peter Bennett |
|---|---|
| Status: | new → assigned |
comment:5 Changed 7 years ago by
| Milestone: | unknown → 29.0 |
|---|---|
| Version: | Unspecified → Master Head |
comment:6 Changed 7 years ago by
I tested patch 0002 without the ffmpeg patch 0001. This works, I see the subtitles in h264 streams as well as in mpeg-2 streams. So it seems the ffmpeg patch may be unnecessary.
comment:7 Changed 7 years ago by
The FFmpeg patch seems to be required for some of my recordings (eg. "Fear the Walking Dead" on AMC; strangely "The Walking Dead" on the same channel is fine without the patch).
Anyway, as I mentioned in comment2, this patch may not be relevant in more recent versions of FFmpeg.
comment:8 Changed 7 years ago by
It seems that "Fear The Walking Dead" is not showing any more, only "The Walking Dead", so I cannot make a test recording. Can you give another example or else provide a sample of a file that does not work.
comment:11 Changed 7 years ago by
| Resolution: | → Fixed |
|---|---|
| Status: | assigned → closed |
Mark as fixed since the MythTV part is done. That fixes many cases. We will be moving to a new version of ffmpeg, which may address the remaining issue.
comment:12 Changed 6 years ago by
| Owner: | changed from Peter Bennett to Peter Bennett |
|---|
libav patch for H.264 A53 captions