Segfault in NuppelVideoRecorder.cpp when profile names has been changed

[are_mythtv@…]

I changed the profile names for Default, High Quality, Low Quality and Live TV to something else. Then when a recording starts, the mythbackend segfaults.

I traced the mythbackend with gdb:

Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 32771 (LWP 22067)] 0xb7daee99 in NuppelVideoRecorder::SetOptionsFromProfile? (this=0xb5db0008,

profile=0xbf3ff774, videodev=@0x811db34, audiodev=@0x811db3c, vbidev=@0x811db38) at NuppelVideoRecorder?.cpp:334

334 QString setting = profile->byName("videocodec")->getValue();

I see in the code that it uses hardcoded names like "Default" and "Live TV". I don't have any experience with the mythtv code, so I don't know if this is intentional or just bad coding.

Anyway, I changed the names back to the originals, and now the it does not segfault anymore.

Since the frontend allows for profile name changing, it should not segfault.

BTW: It did not start to segfault until I rebooted the computer. Everything worked after the namechange before I rebooted...but after the segfaults started coming.

[danielk]

(In [9762]) Fixes #1691. Prevents editing the names of the Default and Live TV recording profiles.

There was also a LineEditSetting::setRW() segfault that needed to be fixed for this to work, and I cleaned up the fillSelections code (used bindValue, checked for DB errors, etc.)