Ticket #1848 (closed patch: fixed)
Opened 7 years ago
Last modified 3 years ago
mythfilldatabase gives too much meaning to TMSDataDirect fccChannelNumber
| Reported by: | awithers | Owned by: | danielk |
|---|---|---|---|
| Priority: | blocker | Milestone: | 0.20 |
| Component: | mythtv | Version: | head |
| Severity: | high | Keywords: | |
| Cc: | Ticket locked: | no |
Description
The fccChannelNumber is incorrectly being used as the frequency id whenever it is found in the station definition. For non-OTA this is bad (you end up with cable channel X being mapped to frequency id Y, when you wanted X=X).
The attached patch only honors the fccChannelNumber as the frequency id if the lineup type is LocalBroadcast?.
Attachments
Change History
comment:1 Changed 7 years ago by awithers
- Owner changed from awithers to danielk
Reassigned so Daniel can apply it after #1966 goes in.
comment:2 Changed 7 years ago by danielk
- Status changed from new to closed
- Resolution set to fixed
(In [10393]) Closes #1848. Only sets freqid in process_dd_station if the listings have the "LocalBroadcast?" type, other TMS listing channel numbers are too unreliable.
comment:3 Changed 7 years ago by ijr
- Status changed from closed to reopened
- Resolution fixed deleted
Not fixed.
comment:4 Changed 7 years ago by ijr
- Priority changed from minor to critical
- Severity changed from medium to high
Upping priority due to causing completely incorrect tuning.
comment:6 Changed 7 years ago by awithers
- Owner changed from danielk to awithers
- Status changed from reopened to new
comment:7 Changed 7 years ago by danielk
comment:8 Changed 7 years ago by awithers
- Status changed from new to closed
- Resolution set to fixed
comment:9 Changed 7 years ago by danielk
- Priority changed from critical to major
- Status changed from closed to reopened
- Resolution fixed deleted
This doesn't yet fix channels inserted with the broken code. See my e-mail.. (Basically, if the mplexid is not valid set freqid and a mplexid of "" should be considered an unset mplexid).
Lowering to "major" since tuning portion is fixed.
comment:10 Changed 7 years ago by danielk
- Owner changed from awithers to danielk
- Priority changed from major to blocker
- Status changed from reopened to new
Fixes for analog have broken initial setup for digital..
I'll try to get this right for both this week.
comment:11 Changed 7 years ago by danielk
- Status changed from new to closed
- Resolution set to fixed
(In [10612]) Fixes #1848. Refs #2053. Allows DTV cards to be hooked up to DataDirect? without manual editing again.
There is still some work to do to prevent mythfilldatabase from mucking with the datadirect lineups when it doesn't need to so I'm keeping #2053 open.
The only time you really need to touch the datadirect lineups are:
- right after a digital channel scan to get the xmltvid matches
- when datadirect tries to add channels to a digital source (so you don't download listings data for an untunable channel).
- when the user explicitly asks you do so to with --remove-new-channels and there are actually new channels to remove.
- when you start up the frontend channel editor, and sometime after you leave it if xmltvid changes are made.
The code is still touching the lineups twice every time mythfilldatabase is run for digital sources, even when every channel has an xmltvid, and after any time you run the frontend channel editor (whether changes were made or not).
