Modify

Ticket #2473 (closed patch: fixed)

Opened 7 years ago

Last modified 7 years ago

Support for 'reversed polarity' LNBs

Reported by: kenny@… Owned by: danielk
Priority: minor Milestone: 0.21
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Circularly polarizied LNBs when attached to satellite dishes that have two reflectors are reversed from their normal polarity (e.g., left-hand circular becomes right-hand circular). This patch adds a checkbox selector to the DiSEqC LNB configuration to support reversing the polarity of the LNB. Note that linear signals (i.e., horizontal and vertical) are not affected by this toggle.

This patch also adds two preset types for the existing circular LNB presets that are the same values but reversed.

Attachments

lnb-reversed.patch (10.8 KB) - added by kenny@… 7 years ago.
Patch to add in reversal of polarity for circularly polarized LNBs
2473-v1.patch (10.7 KB) - added by danielk 7 years ago.
Partially reviewed patch (I need someone with DiSEqC to sanity check this too).
2473-fix-v1.patch (537 bytes) - added by kenny@… 7 years ago.
Fixes single instance of reversed values in SELECT results.
polinv.patch (393 bytes) - added by daniel.chassot@… 7 years ago.
Fix the polarity inversion bool that was not saved in the DB

Change History

Changed 7 years ago by kenny@…

Patch to add in reversal of polarity for circularly polarized LNBs

comment:1 Changed 7 years ago by danielk

  • Milestone changed from unknown to 0.21

Changed 7 years ago by danielk

Partially reviewed patch (I need someone with DiSEqC to sanity check this too).

comment:2 Changed 7 years ago by danielk

  • Status changed from new to closed
  • Resolution set to fixed

(In [11371]) Fixes #2473. Adds support for polarity inversion in DiSEqC setups by applying modified patch from kenny at the b org.

This happens when using an even number of reflectors and a circularly polarized signal. In particular, this is a problem with those oddly shaped dishes that are used to recieve data from two different satelite constellations at once.

comment:3 Changed 7 years ago by anonymous

  • Priority changed from minor to trivial
  • Status changed from closed to reopened
  • Resolution fixed deleted
  • Severity changed from medium to low
  • Type changed from enhancement to defect

In trunk/mythtv/libs/libmythtv/diseqc.cpp

line 1987 " lnb_pol_inv = :POLINV "

should be

line 1987 " lnb_pol_inv = :POLINV, "

missing comma.

comment:4 Changed 7 years ago by danielk

  • Status changed from reopened to closed
  • Resolution set to fixed

(In [11380]) Fixes #2473. Fixes typo in earlier commit.

comment:5 Changed 7 years ago by anonymous

  • Priority changed from trivial to minor
  • Status changed from closed to reopened
  • Resolution fixed deleted
  • Severity changed from low to medium

I looks like the cmd_repeat and inv_pol database items are getting read/written in the wrong order in this patch.

mythconverg.diseqc_tree has lnb_pol_inv as the last item in the table but dieeqc.cpp sometimes has cmd_repeat as last. Check lines starting about 1943

comment:6 Changed 7 years ago by danielk

Can you make a patch?

I don't have DiSEqC, or DVB for that matter, so my write->test->rewrite loop is quite long...

Changed 7 years ago by kenny@…

Fixes single instance of reversed values in SELECT results.

comment:7 Changed 7 years ago by danielk

  • Status changed from reopened to closed
  • Resolution set to fixed

(In [11398]) Really Fixes #2473. Fixes a copy-n-paste error in [11371].. (looked at, and missed by multiple devs, doh!)

comment:8 Changed 7 years ago by rocketr at gmail.com

  • Status changed from closed to reopened
  • Resolution fixed deleted

With this patch mythtv-setup doesn't allow dishpro LNB's to be saved. It also does not allow me to reverse the 'reversed polarity' LNB option.

comment:9 Changed 7 years ago by anonymous

To clarify you can now only select reversed polarity LNB's in mythtv-setup and nothing else. It won't save the setting if you disable reversed polarity.

Changed 7 years ago by daniel.chassot@…

Fix the polarity inversion bool that was not saved in the DB

comment:10 Changed 7 years ago by daniel.chassot@…

  • Type changed from defect to patch

The polarity inverted flag was never saved to the DB due to type error.(svn head rev11464) I've just attached a patch that fixes this (polinv.patch) This is a nasty bug because the scanner is not working while the inversion is wrong!!

comment:11 Changed 7 years ago by danielk

  • Status changed from reopened to closed
  • Resolution set to fixed

(In [11491]) Fixes #2473. Fixes a bug saving the DiSEqC polarity with patch from Daniel Chassot.

We were saving the string value of the checkbox to the DB as an int, which meant it was always true.

With this change we instead use its boolValue() to save the correct value to the DB.

View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.