Ticket #2977 (closed patch: fixed)
Opened 5 years ago
Last modified 5 years ago
id3v1 tags not removed and id3v2 tags not added
| Reported by: | myth@… | Owned by: | stuartm |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.21 |
| Component: | mythmusic | Version: | 0.20 |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
If you have an mp3 file with a id3v1 tag, and you edit the metadata, the id3v1 is left unaltered (although source code comment suggests that it should have been removed) and changes are only stored in the id3v2 tag. And if there was no id3v2 tag, the new metadata is not written.
Attached patch fixes both issues ;
- insert v2 tag if no tag exists
- if writing v2 tag and v1 tag exists, truncate file at v1 tag.
Attachments
-
id3tag.patch
(3.9 KB) -
added by myth@… 5 years ago.
- patch for bug
Change History
Changed 5 years ago by myth@…
-
attachment
id3tag.patch
added
comment:1 Changed 5 years ago by stuartm
- Owner changed from ijr to stuartm
- Status changed from new to assigned
- Milestone changed from unknown to 0.21
comment:2 Changed 5 years ago by stuartm
Eskil, it appears id3v2 tags are being written to the start of the file, but they aren't readable by any id3 tag readers. I'm guessing they aren't formatted correctly. I've not found the cause yet, and I'm not even sure if the problem existed prior to this patch but I thought I should mention it.
comment:3 Changed 5 years ago by stuartm
Never mind, user error, I was testing using apps which don't support ID3v2.4 tags. Surprisingly difficult to find anything supporting v2.4 to test with.
patch for bug