Default CD Device selection

[devel@…]

mythtv-defaultcddevices.diff (No patch dependencies): This patch adds entries in General Settings for specifying default CD and DVD devices to use within MythTV. Adds two database settings: defaultCDDevice and defaultDVDDevice. getCDROMBlockDevices is changed from a protected to a public member in mythmediamonitor.h allowing non class members to enumerate CDROM drives. The stringlist returned from this is used to populate a list of CD/DVD drives in the drive selection comboboxes (comboboxes are left editable should the user wish to manually enter an undetected device).

mythmusic-cddevices.diff (depends on mythtv-defaultcddevices.diff): This patch modifies cd device selection comboboxes to get list of devices from mediamonitor and adds a "default" entry. It also modifies areas of the code which use CD devices to check for "default" and use the mythtv default device if set. cd writer detection using cdrecord --scanbus is removed since this doesn't work on recent kernel versions and instead relies on the user to select a writeable device.

mythvideo-cddevices.diff (depends on mythtv-defaultcddevices.diff): This patch modifies VCD and DVD device selection comboboxes to get list of devices from mediamonitor and adds a "default" entry. It also modifies areas of the code which use CD devices to check for "default" and use the mythtv default device if set.

mytharchive-cddevices.diff (depends on mythtv-defaultcddevices.diff): This patch modifies DVD device selection comboboxes to get list of devices from mediamonitor and adds a "default" entry. It also modifies mytharchivehelper/main.cpp and mythburn.py to check for "default" and use the mythtv default device if set.

[devel@…]

Add default cd/dvd device selection

[devel@…]

Add default cd/dvd device selection to mytharchive

[devel@…]

Add default cd/dvd device selection to mythmusic

[devel@…]

Add default cd/dvd device selection to mythvideo

[nigel]

Small review
1) I agree that having a default device selector is useful, and having the burning functions seperate is also good. Having four defaults seems overkill, though? Maybe just one DefaultBurner? setting?
2) Most of your code compares the *DeviceLocation? setting to "default", and then looks up another setting. Why not just use the first setting? (i.e. make the UI GetCDROMBlockDevices changes in programs/mythfrontend/globalsettings.cpp)
3) mythvideo/mythvideo/main.cpp adds "/2" onto the URL/URI/MRI/thingy. Why? Doesn't this always force one particular track?
4) Prepending /dev into the paths in the GUI selectors is a bit wasteful, and won't work on Windows or Mac OS X. (Note, however, that I do something equally bad in mythvideo/main.cpp on OS X). Maybe a new method, MythMediaMonitor::GetCDMedias() that already prepends this for appropriate OSs?
5) I am wondering if the user really needs the /dev name in the GUI selector? Ideally, we would present the device name (e.g. "PIONEER DVD-RW DVR-108" or "LITE-ON DVDRW SOHW-832S") parsed from /proc/ide/hd?model

[devel@…]

Mythvideo patch v2 removes "/2" from device that accidently slipped into the patch

[devel@…]

Please mark this ticket as invalid for now since it will no longer apply to head. I need to review the mythmediamonitor changes by Nigel and provide an updated patch.

[nigel]

MythMedia based auto-selection

[nigel]

MythMedia changes attached, only slightly tested.

[devel@…]

Updated default-cd.diff patch: -Fixes typo in mytharchive part (defaultDVDWriter->defaultWriter). -Adds missing bits to mythmusic (playback).

I've tested the CD parts of this, with a single cd drive. It'll be a few days before I can sort out a second drive and a dvd disk to test with. Looks good so far though.

mythburn.py uses MythArchiveDVDLocation which needs to change to use MediaMonitor:defaultWriter somehow - not sure how to do this though given it's a python script.

[devel@…]

Updated patch

[nigel]

(In [13225]) New methods for getting default CD/VCD/DVD/burner, for plugins. See #3077

[nigel]

(In [13228]) Cut/paste error. See #3077

[nigel]

(In [13284]) Refine drive selection popup. See #3077. Now lists CDROMs, not ejectables. Requires RTTI, but that shouldn't be a problem (other parts of MythTV do also)

[nigel]

(In [13336]) Don't lookup CD device in decoder, set it in the parent. See #2598. See #3077

[nigel]

(In [13358]) Multi CD drive selection in MythMusic. To test it, you need to set the CDDevice setting to "default", but in the future this setting will vanish. See #3077

[nigel]

(In [13362]) Multiple CD drive with media manager in Music Plugin. See #3077. See #2598

[nigel]

(In [13364]) Multiple DVD drive with media manager in Video Plugin. See #3077. See #2598. Not real happy about the structure here (TitleDialog? and DVDRipBox need to share the same dvd_device, and it the needs to get passed to mtd for use?), but that will have to wait for some extra, um, "brave pills". Until then, setting DVDDeviceLocation to "default" should let you play from multiple drives, but will break ripping.

[devel@…]

Fix model lookup for cd devices with scd0/sr0 device names

[nigel]

OK. The only parts that I have not committed are the mtd default (which cannot use the defaultDVD method as it stands, because on a multiple DVD machine, it will try and pop up a dialog box), and the removal of the setup (UI) stuff. [BR]] The former needs something like a "non-interactive" flag in the methods. I had a reworking of mtd that let callers pass in the drive to monitor, but lost that when a disk image went bad. For now, it can probably stay as is.
The latter? I am still thinking about whether the UI should let the user choose default or a drive from a list, or if it should just be completely missing.
Either way, I think it is time to close this ticket