Modify ↓

Ticket #3257 (closed enhancement: fixed)

Opened 5 years ago

Last modified 5 years ago

Patch to accelerate scrolling within mythmusic

Reported by: anonymous Owned by: ijr
Priority: minor Milestone: 0.21
Component: mythmusic Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

Trying to make mythmusic a little more pleasent to use with large libraries. Attached is a patch that will speed up scrolling after several songs (simalar to an iPod).

Thanks, Craig.

Attachments

speedScrolling.patch​ (3.6 KB) - added by craig@… 5 years ago.
ui.patch​ (2.9 KB) - added by craig@… 5 years ago.

Change History

Changed 5 years ago by craig@…

Changed 5 years ago by craig@…

comment:1 Changed 5 years ago by paulh

Please use the proper coding standards in the future - mainly don't use tabs and use one space after if. Thanks.

​http://www.mythtv.org/wiki/index.php/Coding_Standards

comment:2 Changed 5 years ago by paulh

(In [13140]) The libmyth part of a patch by Craig to speed up scrolling in MythMusic's playbackbox. Increases the scroll speed if up/down is help down for a while.

Changes the plugin api so a recompile of the plugins is required.

Refs #3257.

comment:3 Changed 5 years ago by paulh

  • Status changed from new to closed
  • Resolution set to fixed

(In [13141]) The MythMusic part of a patch by Craig to speed up scrolling in MythMusic's playbackbox. Increases the scroll speed if up/down is held down for a while.

Requires r13140 of MythTV to be compiled _and_ installed.

Closes #3257.

comment:4 Changed 5 years ago by anonymous

  • Status changed from closed to reopened
  • Resolution fixed deleted

Seems that changeset 13141 has introduced the following error when compiling after a "make distclean": 

playbackbox.cpp: In member function `virtual void PlaybackBoxMusic::keyPressEvent(QKeyEvent*)':
playbackbox.cpp:455: error: 'class UIManagedTreeListType' has no member named 'moveUpByAmount'
playbackbox.cpp:476: error: 'class UIManagedTreeListType' has no member named 'moveDownByAmount'
make[2]: *** [playbackbox.o] Error 1

This was the latest SVN (r13149). I will look furhter into if I get time (it will take me a while as I have never written a line of cpp in my life, not even hello world) :)

comment:5 Changed 5 years ago by anonymous

  • Priority changed from minor to major
  • Type changed from enhancement to defect
  • Severity changed from low to high

It seems that the ui.patch wasn't applied in changeset [13141].

comment:6 Changed 5 years ago by stuartm

  • Status changed from reopened to closed
  • Resolution set to fixed

The ui patch was applied in [13140], as the commit message said "Requires r13140 of MythTV to be compiled _and_ installed."

comment:7 Changed 5 years ago by stuartm

  • Priority changed from major to minor
  • Type changed from defect to enhancement
  • Severity changed from high to low

comment:8 Changed 5 years ago by stuartm

  • Milestone changed from unknown to 0.21

comment:9 Changed 5 years ago by stuartm

(In [14811]) Reduce the speed and timeout of the mythmusic speed scrolling added in [13141].

The current values were driving me mad as I'd attempt to scroll down a screens worth of tracks and end up 500 tracks away from where I started.

The timeout change was fine with my remote, but you may need to tweak the repeat rate in your lirc config if speed scrolling appears to stop working for you.

Refs #3257

View ↑

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.