Modify ↓

Ticket #3545 (closed defect: fixed)

You must read the TicketHowTo before creating a new ticket or commenting on an existing ticket.

Opened 5 years ago

Last modified 5 years ago

mythmusic not playing complete .flac files when compiled with flac-1.1.4

Reported by: anonymous Owned by: stuartm
Priority: minor Milestone: 0.21
Component: mythmusic Version: 0.20-fixes
Severity: medium Keywords: mythmusic flac
Cc: Ticket locked: no

Description

upon attempting to play a .flac file, mythmusic plays *maybe* the first decoded frame, then moves on to the next file. this appears to happen because the flacdecoder isn't checking for some of the newer non-error status codes returned by the flac decoder lib in 1.1.4.

i've patched the flacdecoder.cpp file of mythmusic to take the new status codes into account. note: the patch is probably not compatible with much older versions of flac (probably needs some fine tuning based on flac api version).

Attachments

mythmusic-flac-1.1.4.patch Download (1.3 KB) - added by james_defelice@… 5 years ago.
patch for flacdecoder.cpp
mythmusic_flac_decoder_state.diff Download (2.5 KB) - added by stuartm 5 years ago.
Patch which should work against 1.1.2

Change History

Changed 5 years ago by james_defelice@…

patch for flacdecoder.cpp

comment:1 Changed 5 years ago by stuartm

  • Owner changed from ijr to stuartm
  • Status changed from new to assigned

Changed 5 years ago by stuartm

Patch which should work against 1.1.2

comment:2 Changed 5 years ago by stuartm

  • Milestone changed from unknown to 0.21

Could you try the patch I've attached? It does the same as your patch but should build and work on systems with Flac 1.1.2 installed as well as those with 1.1.3. and 1.1.4.

comment:3 Changed 5 years ago by stuartm

  • Status changed from assigned to closed
  • Resolution set to fixed

(In [13663]) Fixes playback with Flac 1.1.4 by accounting for some new decoder state codes. Based on a patch by James Defelice which I modified to work with older versions of Flac.

Thanks to everyone who confirmed that this did indeed build and work on versions 1.1.2 and 1.1.4

Closes #3545

comment:4 Changed 5 years ago by ijc@…

Hello,

Would it be possible to have this patch applied to the release-0.20-fixed branch? It applies cleanly for me here.

Many thanks, Ian.

comment:5 Changed 5 years ago by stuartm

(In [14089]) Backports [13663] Flac 1.1.4 support to -fixes.

Refs #3545

View ↑

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.