mythfilldatabase erroneously deletes record schedules for the current day

[Tom Dexter <digitalaudiorock@…>]

mythfilldata always deletes records from the record table with types of single, override, or dontrecord whose enddate is the current day.

The problem is in the clearOldDBEntries in the file programs/mythfilldatabase/filldata.cpp (in 0.20) and libs/libmythtv/programdata.cpp (in 0.21):

query.prepare("DELETE FROM record WHERE (type = :SINGLE "

"OR type = :OVERRIDE OR type = :DONTRECORD) " "AND enddate < NOW();");

query.bindValue(":SINGLE", kSingleRecord); query.bindValue(":OVERRIDE", kOverrideRecord); query.bindValue(":DONTRECORD", kDontRecord); query.exec();

Since enddate is a date column (not datetime) it's getting compared to NOW() as a datetime at 12:00AM, thus always less than NOW(). Using either CURDATE(), CURRENT_DATE, or CAST(NOW() AS DATE) in place of NOW() would work correctly.

[Jeff <jeff@…>]

This also drives me insane.

[anonymous]

We don't need "Me too" posts.

[Jeff <jeff@…>]

a patch

[Jeff <jeff@…>]

Replying to anonymous:

We don't need "Me too" posts.

Sorry.

[Tom Dexter <digitalaudiorock@…>]

Just curious...is this also going to get patched in the release-0-20-fixes branch (in programs/mythfilldatabase/filldata.cpp)?

Thanks.

[stuartm]

(In [13793]) Fixes #3681

Use CURDATE() instead of NOW() to prevent ProgramData::clearOldDBEntries deleting certain recording rules early.

[stuartm]

(In [13794]) Backport [13793] to -fixes.

Fix certain recording rule types being deleted early by mythfilldatabase.

Refs #3681