Modify

Ticket #4056 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

deleted (but in deleted group) prevent new recordings via "still available in list of recordings"

Reported by: xris Owned by: skamithi
Priority: minor Milestone: unknown
Component: mythtv Version: unknown
Severity: medium Keywords:
Cc: Ticket locked: no

Description

I've been getting a lot of zero-byte recordings lately (another issue), and noticed that if I delete these (#3872 explains why they shouldn't exist in the first place), MythTV will no longer re-schedule a new recording to replace them because the old one "still exists" in the Deleted group. It's annoying to have to go in and "delete forever" again to get them to re-record.

Attachments

ignore_programs_in_deleted_recgroups.diff (559 bytes) - added by skamithi 5 years ago.
ignore programs in "Deleted" recgroup during scheduling checks.
scheduler.diff (990 bytes) - added by xris 5 years ago.

Change History

comment:1 Changed 5 years ago by skamithi

  • Owner changed from ijr to skamithi

comment:2 Changed 5 years ago by skamithi

  • Status changed from new to closed
  • Resolution set to fixed

(In [14619]) Closes #4056 Refs #3788. if filesize < 1mb don't mark the show for deletion if this feature is enabled , just delete it.

comment:3 Changed 5 years ago by xris

You sure this is the full solution? There may be times when users aren't aware that the recording is still in the deleted group (because of display filters). If the deleted group is just as good as actually deleted, shouldn't the scheduler ignore things in the deleted recgroup, as far as dupe checking is concerned? Either that, or we should consider some kind of UI to auto-undelete things when people try to re-record them (in case the recording was only partial, or was somehow corrupt, not just zero-bytes).

comment:4 Changed 5 years ago by skd5aner@…

  • Status changed from closed to reopened
  • Resolution fixed deleted

I agree with xris. This should be irrelavent if the recording was zero-byte or not. Not just for re-records, but for max recording rules. If I have a max recording of 1, watch that recording and "delete it", I will want the scheduler to record another now that I have "deleted" the one I had. For all intensive purposes, I would think the undelete group would simply treat anything in it as completely deleted.

Changed 5 years ago by skamithi

ignore programs in "Deleted" recgroup during scheduling checks.

comment:5 Changed 5 years ago by skamithi

pls test patch. gave it a quick test drive. seems to work.

comment:6 Changed 5 years ago by xris

I'd personally go for "NOT IN ('LiveTV','Deleted')" but I don't know how it'd work in mysql 3.x, or be affected by indexing. Anyway, that patch should work just fine, although it misses another place that it should probably be. I'll attach my diff in a sec.

Changed 5 years ago by xris

comment:7 Changed 5 years ago by skamithi

(In [14623]) Refs #4056 Refs #3788. make scheduler ignore programs in the 'Deleted' recgroup. patch provided by xris.

comment:8 Changed 5 years ago by skamithi

  • Status changed from reopened to closed
  • Resolution set to fixed
View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.