Ticket #4504 (closed enhancement: fixed)
Opened 4 years ago
Last modified 3 months ago
Extend guide to show unavailable channels in a different color (multirec)
| Reported by: | Mark Buechler <Mark.Buechler@…> | Owned by: | stuartm |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.25 |
| Component: | MythTV - User Interface Library | Version: | head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
This patch extends the idea of showing unavailable channels in the channel column with a "X" buy giving those channels a different theme-able color. It also prevents the guide from closing if you select an unavailable channel. In order for this to work, the following needs added to your theme in the "guide" container:
<unavailablecolor>#ff0000</unavailablecolor>
Attachments
Change History
Changed 4 years ago by Mark Buechler <Mark.Buechler@…>
- Attachment guide_unav.diff added
comment:1 Changed 4 years ago by Mark Buechler <Mark.Buechler@…>
Note, the same problem in 4503 still exists here.
comment:2 Changed 4 years ago by danielk
- Owner changed from ijr to danielk
- Status changed from new to assigned
- Milestone changed from unknown to 0.21
comment:3 Changed 4 years ago by danielk
- Status changed from assigned to infoneeded
Mark, can you update this to apply to the latest svn?
The code in isUnavailable() probably needs changing to match the fix where chinfo is repulled when trying alternatives with the same channum.
comment:4 Changed 4 years ago by Mark Buechler <Mark.Buechler@…>
Daniel, can you point me to that patch?
Thanks, Mark.
comment:5 Changed 4 years ago by danielk
- Status changed from infoneeded to assigned
Sorry, this was a local patch. Janne has already committed a different fix, so there is no need for any updated patch from you. I'm testing this now.
comment:6 Changed 4 years ago by danielk
comment:7 Changed 4 years ago by danielk
- Milestone changed from 0.21 to unknown
Mark, I like the concept but I think this requires a little more work. As is, this color color is overridden if something is marked with another color (say for a scheduled recording). Also the suggested 'red' is also the same color as the news item category color. I think it would make more sense if this modified the existing saturation or intensity color, so that all scheduled items would shift noticibly toward grey when the channel is in unavailable.
In the meantime, I've implemented a 'graying' of the channel name text in the EPG for unavailable channels (and a yellowing for favorite channels).
comment:8 Changed 3 years ago by stuartm
- Owner changed from danielk to stuartm
- Status changed from assigned to accepted
- Component changed from mythtv to MythTV - User Interface Library
- Milestone changed from unknown to 0.23
I'll see how we can work this into a mythui guide using statetypes, so the exact representation would be up to the themer.
comment:10 Changed 22 months ago by robertm
- Milestone changed from 0.24 to 0.25
Unlikely to be touched for .24
comment:12 Changed 3 months ago by Github
- Status changed from accepted to closed
- Resolution set to fixed
GuideGrid? was missing statetype corresponding to existing text state. Fixes #4504
Branch: master Changeset: 3e7f41e1f17c2f0ae86ec26fa4f3a3b1aef8f957
The patch