Ticket #5338 (closed enhancement: fixed)
Opened 4 years ago
Last modified 3 years ago
Watched flag for mythvideo
| Reported by: | ille | Owned by: | robertm |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.22 |
| Component: | mythvideo | Version: | head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
A patch against 0.21-fixes as a first step that implements a watched flag in the database and a "Toggle watched" item under the info button in the different views and in the video manager. The filter function is updated with this new flag so you can filter and only present what is not watched.
The next step would be make the watched flag toggle as on tv-recordings and make the flag somehow change the color of a not watched movie.
Tha patch is against 0.21-fixes , i would guess it needs to be written against SVN.
Attachments
Change History
comment:1 Changed 4 years ago by awithers
- Owner changed from ijr to awithers
- Status changed from new to assigned
- Component changed from mythtv to mythvideo
Feature patches, not generated from trunk, are at the bottom of the pile.
comment:2 Changed 4 years ago by yourimatthys@…
Applied you patch against SVN and the toggling works as expected. Had to exclude the patch for videofilter.cpp though as make didn't want to compile. Gave me an error on kWatchedFilterAll.
comment:3 follow-up: ↓ 4 Changed 4 years ago by yourimatthys@…
Should I create the diffs for the SVN?
comment:4 in reply to: ↑ 3 Changed 4 years ago by anonymous
Replying to yourimatthys@gmail.com:
Should I create the diffs for the SVN?
yes you could, but would be great if you could post the compile error for videofilter.cpp
comment:5 Changed 3 years ago by stuartm
- Status changed from assigned to infoneeded
- Milestone changed from 0.21.1 to 0.22
Please update the patch for trunk
comment:6 Changed 3 years ago by robertm
- Status changed from infoneeded to assigned
- Version changed from 0.21-fixes to head
I have a trunk version of this mostly done, will commit in the next few days.
Changed 3 years ago by robertm
- Attachment MythVideo.Watched.081109.diff added
Preliminary patch for trunk. Theme support not included yet.
comment:8 Changed 3 years ago by robertm
- Status changed from assigned to closed
- Resolution set to fixed
(In [21217]) Closes #5338. Adds a 'Watched' Flag to MythVideo? to match the one in Watch Recordings. Operates exactly as in recordings-- If the setting to automatically mark recordings as watched is on, videos will also be automatically marked as watched using the same method. Otherwise, one can mark a video watched in MythVideo? in the Edit Metadata screen or in Manage Video->Toggle Watched. Can sort by watched. Suffers from the same bug as scanning-- when a video is marked as watched during playback, it will not stick in the UI until leaving MythVideo? and waiting for the cache to die.
