Modify ↓

Ticket #5498 (closed patch: fixed)

Opened 4 years ago

Last modified 3 years ago

ALSA getSpaceOnSoundcard mixing frames and bytes

Reported by: David Asher <david.asher@…> Owned by: danielk
Priority: minor Milestone: 0.22
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

I'm using release-0-21-fixes, so that's what the patch is against.

This is a minor issue, since I think it will only matter in an error case, but the return value of snd_pcm_avail_update() (which is in frames) is being compared to soundcard_buffer_size (which is in bytes). The attached patch is untested (my current system is not set up to compile mythtv).

Attachments

audiooutputalsa.cpp.patch​ (709 bytes) - added by David Asher <david.asher@…> 4 years ago.
patch to compare bytes with bytes

Change History

Changed 4 years ago by David Asher <david.asher@…>

patch to compare bytes with bytes

comment:1 Changed 3 years ago by danielk

  • Owner changed from ijr to danielk
  • Status changed from new to assigned

comment:2 Changed 3 years ago by danielk

  • Version changed from unknown to head
  • Type changed from defect to patch
  • Milestone changed from unknown to 0.22

comment:3 Changed 3 years ago by danielk

  • Status changed from assigned to closed
  • Resolution set to fixed

(In [19473]) Fixes #5498. Fixes frame vs. bytes confusion in ALSA error check.

View ↑

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.