Modify

Ticket #5510 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

compile parse error in jobsqueue member function QueueJobs

Reported by: Erik Hovland <erik@…> Owned by: ijr
Priority: trivial Milestone: unknown
Component: mythtv Version: 0.21-fixes
Severity: low Keywords:
Cc: Ticket locked: no

Description

Because a ctor for QDateTime is called with the class scope the g++ compile throws a parse error. Now this is not a parse error that ever gets thrown out to the user. Instead g++ notices it and says 'Oh, what they really want is this' and moves on. But programs that use the parsed output of the compiler (like static analysis checkers) cannot analyze the source code that includes this header file. So that means that the analyzer cannot check things like tv_rec.cpp, tv_play.cpp or NuppleVideoPlayer??.cpp. Which are perhaps some of the most heavily used classes in libmythtv. So it would be nice if this one liner could be put in fairly soon.

This is the same as ticket #5423. But the patch is for 0.21-fixes

Attachments

0.21-fixes-jobqueue-scoping.patch (678 bytes) - added by Erik Hovland <erik@…> 4 years ago.
removes scoping from ctor to avoid compile time parsing errors

Change History

Changed 4 years ago by Erik Hovland <erik@…>

removes scoping from ctor to avoid compile time parsing errors

comment:1 Changed 4 years ago by danielk

  • Status changed from new to closed
  • Resolution set to fixed

(In [17773]) Fixes #5510. Removes incorrect scoping on a QDateTime ctor in fixes.

View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.