Modify ↓

Ticket #5675 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

buttontemplate in MythUIButtonList::Init is always set, no checking required

Reported by: Erik Hovland <erik@…> Owned by: stuartm
Priority: trivial Milestone: 0.22
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

thanks to the magic of previous checks buttontemplate has to be valid. So the checks in Init() are not necessary (and are in fact unexecutable code).

Attachments

libs_libmythui-deadcode.patch​ (1.1 KB) - added by Erik Hovland <erik@…> 4 years ago.
Removes unexecutable code
libs_libmythui-deadcode.2.patch​ (756 bytes) - added by Erik Hovland <erik@…> 4 years ago.
modified after ticket #5502 patch was properly changed

Change History

Changed 4 years ago by Erik Hovland <erik@…>

Removes unexecutable code

comment:1 Changed 4 years ago by stuartm

  • Owner changed from ijr to stuartm
  • Status changed from new to assigned
  • Milestone changed from unknown to 0.22

What version was this against? Although I see the first check in Init() (added in [18087]), the second doesn't appear in [18254].

comment:2 Changed 4 years ago by Erik Hovland <erik@…>

Dang monster patch set. The patch for ticket #5502 re-adds the check. Attached is the new patch w/out the second check. I am also going over to #5502 and submitting a new patch there.

Changed 4 years ago by Erik Hovland <erik@…>

modified after ticket #5502 patch was properly changed

comment:3 Changed 4 years ago by stuartm

  • Status changed from assigned to closed
  • Resolution set to fixed
View ↑

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.