Modify

Ticket #5738 (closed defect: wontfix)

Opened 4 years ago

Last modified 4 years ago

Channels to Display is being altered for program guide in live tv.

Reported by: Juppers Owned by: ijr
Priority: minor Milestone: 0.21.1
Component: mythtv Version: 0.21-fixes
Severity: low Keywords:
Cc: Ticket locked: no

Description

Number of Channels to Display in the program guide is being futzed with for no apparent reason. Maybe at one time it needed messing with? It doesn't need it anymore that I can find. Commenting out or removing the following bit of code from guidegrid.cpp fixes the issue.

Index: libs/libmythtv/guidegrid.cpp =================================================================== --- libs/libmythtv/guidegrid.cpp (revision 18397) +++ libs/libmythtv/guidegrid.cpp (working copy) @@ -202,9 +202,6 @@

int dNum = gContext->GetNumSetting?("chanPerPage", 8);

  • if (m_player && m_player->IsRunning?() && allowsecondaryepg)
  • dNum = dNum * 2 / 3 + 1;

-

desiredDisplayChans = DISPLAY_CHANS = dNum; if (container) {

Attachments

Change History

comment:1 Changed 4 years ago by Dibblah

  • Status changed from new to infoneeded_new

This was added in: http://svn.mythtv.org/trac/changeset/4385 -

To compare the space available, please see: http://www.mythtv.org/mythimages/epg.png and http://www.mythtv.org/mythimages/epgvideo.png

(Although these images do not show the effect of this code)

What is the issue you are seeing?

Cheers,

Allan.

comment:2 Changed 4 years ago by Juppers

I'm seeing when I tell it to show 8 rows, it may show 6. Not all themes change the guide size like the example you posted creating the same effect in reverse, blootube-wide is one, I belive glass is another. I see where the code is needed for the ones that do though. would be great if it would scale based on the guide bounding box difference between the 2 guide types.

comment:3 Changed 4 years ago by stuartm

  • Status changed from infoneeded_new to closed
  • Resolution set to wontfix

This code is being re-written for 0.22, in the new version the number of channels visible will be defined by the theme.

View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.