Modify

Ticket #6289 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

MythWeb recorded programs RSS and non-ascii characters in titles

Reported by: otto at kolsi dot fi Owned by: kormoc
Priority: minor Milestone: unknown
Component: Plugin - MythWeb Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

MythWeb Recorded Programs RSS feed breaks if program titles contain non-ascii characters. For example, title "Tv-uutiset ja sää" becomes:

<title>Tv-uutiset ja s&Atilde;&curren;&Atilde;&curren;</title>

Adding utf8_decode() call to tv/tmpl/rss/recorded.php where title is set, makes it better:

<title>Tv-uutiset ja s&auml;&auml;</title>

but it is still broken because of the entities (http://validator.w3.org/feed/). Is it possible to output this RSS-feed through MythWeb without doing the entity encoding for this file?

Attachments

mythweb-feed-non-ascii.patch (1.0 KB) - added by otto at kolsi dot fi 3 years ago.

Change History

comment:1 Changed 3 years ago by kormoc

  • Owner changed from xris to kormoc
  • Status changed from new to accepted

comment:2 Changed 3 years ago by kormoc

  • Status changed from accepted to closed
  • Resolution set to fixed

(In [20244]) Hopefully fixes #6289, converts utf-8 to iso8859-1 and urldecodes them.

Changed 3 years ago by otto at kolsi dot fi

comment:3 Changed 3 years ago by otto at kolsi dot fi

[20244] did not fix this, ticket should be re-opened (don't have permissions to do so).

Root of the problem seems to be the fact that FeedWriter?.php does HTML entity encoding for the RSS data. RSS data is in fact XML and thus most of the HTML entities do not work but break the XML (since without additional declarations, XML can contain only 5 entities).

Attached patch removes HTML-entity encoding and also removes previous UTF-8/URL -decode calls (which now need to be removed when entities are not used). With this applied, non-ascii characters work both in program titles and descriptions.

comment:4 Changed 3 years ago by kormoc

  • Status changed from closed to new
  • Resolution fixed deleted

comment:5 Changed 3 years ago by kormoc

  • Status changed from new to closed
  • Resolution set to fixed

(In [20392]) Fixes #6289, allows non-ascii rss feeds to work correctly

View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.