Ticket #6318 (closed enhancement: fixed)
Opened 4 years ago
Last modified 3 years ago
recGroup direct access for PBB
| Reported by: | jppoet@… | Owned by: | danielk |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.23 |
| Component: | MythTV - User Interface Library | Version: | head |
| Severity: | medium | Keywords: | mythui recording groups |
| Cc: | Ticket locked: | no |
Description
The recGroup-cycle.patch adds the ability to cycle through the user defined recording groups directly using the PAGERIGHT and PAGELEFT keys while in the PBB. This is much faster than bringing up the menu, and selecting which recording group to view.
The recGroup-ui.patch lets the theme optionally display the list of recording groups, with the current group highlighted.
The recGroup-Terra.patch, recGroup-default-wide.patch and recGroup-metallurgy_svn_10_01_09.patch(es) are not really polished. I am including them to demonstrate what a theme needs to do, to take advantage of the recGroup-ui feature. I also figured it would make it easier to review these patches.
I have almost 1300 recordings. Using these patches makes it much quicker to find the show I want to watch, by significantly reducing the amount of data I have to page through.
Attachments
Change History
comment:1 Changed 4 years ago by jppoet@…
Replaced the recGroup-cycle patch, with one that removes some useless code.
Changed 4 years ago by jppoet@…
- Attachment recGroup-cycle-v1.1.patch added
new version with recGroupType getting set properly
comment:2 Changed 4 years ago by jppoet@…
Attached a new version of recGroup-cycle. Just adds one line, to get recGroupType set properly.
comment:3 Changed 4 years ago by stuartm
- Version changed from unknown to head
- Type changed from patch to enhancement
- Milestone changed from unknown to 0.23
Changed 4 years ago by jppoet@…
- Attachment recGroup-Terra.2.patch added
Updated patch for the Terra theme
Changed 4 years ago by jppoet@…
- Attachment recGroup-default-wide.2.patch added
Updated patch for the default-wide theme
Changed 4 years ago by jppoet@…
- Attachment recGroup-metallurgy_svn_10_01_09.2.patch added
Update patch for the metallurgy theme
comment:4 Changed 4 years ago by jppoet@…
Added updated patches for the themes.
comment:5 Changed 4 years ago by doug@…
I realize I'm just one user, but I wanted to throw my two cents behind this patch (recGroup-cycle-v1.1.patch). I have the same problem as jppoet (lots of recordings in different groups) and this patch makes my myth experience significantly better.
Thanks jppoet! -Doug
comment:6 Changed 4 years ago by cpinkham
(In [21261]) Allow the PAGELEFT and PAGERIGHT keybindings to cycle through Recording Groups in the Watch Recordings screen.
References #6318. I'll let Stuart look the UI/theme patch attached to the ticket since he took this ticket a few months ago.
This patch is by John P Poet, but I added the locking around the Recording Group cache so that we don't try to access the cache while it is being rebuilt by PlaybackBox::FillList?().
Changed 4 years ago by jppoet@…
- Attachment recGroup-Terra.3.patch added
Update Terra patch for trunk 21437
comment:7 Changed 4 years ago by jppoet@…
Added a new recGroup-Terra.3.patch for trunk 21437
Changed 4 years ago by jppoet@…
- Attachment recGroup-default-wide-v2.patch added
Minor optimizations
Changed 4 years ago by jppoet@…
- Attachment recGroup-metallurgy_svn_10_01_09-v2.patch added
Minor optimizations
comment:9 Changed 4 years ago by jppoet@…
New UI patches as a result of suggestions by Stuart Morgan.
comment:10 Changed 4 years ago by jppoet@…
Oops. recGroup-ui-v2.patch had one-line of residue from a different patch. Attaching recGroup-ui-v2a.patch, which has that residue removed.
comment:11 Changed 4 years ago by jppoet@…
new recGroup-ui-v2.1.patch updated for r22552.
Changed 4 years ago by John Patrick Poet <jppoet@…>
- Attachment recGroup-default-v1.patch added
Changed 4 years ago by John Patrick Poet <jppoet@…>
- Attachment recGroup-default-wide-v3.patch added
Changed 4 years ago by John Patrick Poet <jppoet@…>
- Attachment recGroup-Terra-v5.patch added
Changed 4 years ago by John Patrick Poet <jppoet@…>
- Attachment recGroup-Graphite-v1.patch added
Changed 4 years ago by John Patrick Poet <jppoet@…>
- Attachment recGroup-metallurgy-v2.patch added
comment:12 Changed 4 years ago by John Patrick Poet <jppoet@…>
Changed 4 years ago by John Patrick Poet <jppoet@…>
- Attachment recGroup-ui-v3.patch added
Don't display recGroup buttonlist if there is only one recording group.
comment:13 Changed 4 years ago by John Patrick Poet <jppoet@…>
New version of patch (v3) which will not draw the recGroup buttonlist if there is only one item in it.
comment:14 Changed 3 years ago by managementboy@…
patch does not apply anymore with trunk 23063.
patching file programs/mythfrontend/playbackbox.cpp Hunk #1 succeeded at 474 (offset 38 lines). Hunk #2 succeeded at 492 (offset 39 lines). Hunk #3 FAILED at 942. Hunk #4 succeeded at 1273 (offset 68 lines). Hunk #5 FAILED at 1737. 2 out of 5 hunks FAILED -- saving rejects to file programs/mythfrontend/playbackbox.cpp.rej patching file programs/mythfrontend/playbackbox.h Hunk #1 FAILED at 314. Hunk #2 FAILED at 328. 2 out of 2 hunks FAILED -- saving rejects to file programs/mythfrontend/playbackbox.h.rej
comment:15 Changed 3 years ago by jppoet@…
Patch v4 added with compatibility for r23048.
comment:16 Changed 3 years ago by danielk
- Owner changed from stuartm to danielk
- Status changed from accepted to assigned
comment:17 Changed 3 years ago by danielk
- Status changed from assigned to closed
- Resolution set to fixed
