Modify

Ticket #6536 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Segfault in MythWeather

Reported by: Marc Alban <marcalban@…> Owned by: ijr
Priority: minor Milestone: 0.22
Component: Plugin - MythWeather Version: head
Severity: medium Keywords: segfault
Cc: Ticket locked: no

Description

1) Enter the MythWeather? screen. 2) Press 'MENU'. 3) While the busy dialog is showing press 'ESC'.

The escape key press is not being handled by the busy dialog and is causing the the underlying weather dialog to deallocate while the source manager is still processing.

Attached is a backtrace and a patch which adds an optional parameter to the busy and progress dialogs to make them modal. This will ensure that the processing has completed before deallocating.

Attachments

mythweather.backtrace (17.6 KB) - added by Marc Alban <marcalban@…> 3 years ago.
backtrace
mythweather_fix.patch (4.7 KB) - added by Marc Alban <marcalban@…> 3 years ago.
patch to fix seg fault in MythWeather?
mythweather_fix.2.patch (1.0 KB) - added by Marc Alban <marcalban@…> 3 years ago.
Alternate patch to fix segfault in MythWeather?.
mythweather_fix.3.patch (1.0 KB) - added by Marc Alban <marcalban@…> 3 years ago.
Updating patch to trunk.
mythweather.2.backtrace (2.4 KB) - added by Marc Alban <marcalban@…> 3 years ago.
Backtrace of segfault in the MythWeather? screen setup window.
mythweather_fix.4.patch (3.2 KB) - added by Marc Alban <marcalban@…> 3 years ago.
An updated patch to fix both segfaults.

Change History

Changed 3 years ago by Marc Alban <marcalban@…>

backtrace

Changed 3 years ago by Marc Alban <marcalban@…>

patch to fix seg fault in MythWeather?

comment:1 Changed 3 years ago by danielk

  • Type changed from patch to defect

We don't want modal dialog handling with MythUI so the patch is not useful, but the backtrace is.

Changed 3 years ago by Marc Alban <marcalban@…>

Alternate patch to fix segfault in MythWeather?.

Changed 3 years ago by Marc Alban <marcalban@…>

Updating patch to trunk.

comment:2 Changed 3 years ago by Marc Alban <marcalban@…>

I found another segfault in the screen setup window.

To reproduce:

  • Enter MythWeather? screen setup window
  • Select an existing screen on the right side
  • Press 'Enter'
  • Press 'Esc'

Changed 3 years ago by Marc Alban <marcalban@…>

Backtrace of segfault in the MythWeather? screen setup window.

Changed 3 years ago by Marc Alban <marcalban@…>

An updated patch to fix both segfaults.

comment:3 Changed 3 years ago by paulh

(In [21104]) Fix a segfault in MythWeather?'s setup screen when escaping out of the popup menu. Patch from Marc Alban. Refs #6536.

comment:4 Changed 3 years ago by paulh

  • Status changed from new to closed
  • Resolution set to fixed

(In [21456]) Ignore Escape in the busy and progress dialogs. Fixes #6536.

View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.