Ticket #6681 (closed patch: Unverified)
Opened 3 years ago
Last modified 21 months ago
Switching between Video and TV over PiP Video always starts at latest Bookmark
| Reported by: | Frank Sagurna <fgunni@…> | Owned by: | gnome42 |
|---|---|---|---|
| Priority: | minor | Milestone: | unknown |
| Component: | MythTV - Video Playback | Version: | Unspecified |
| Severity: | low | Keywords: | |
| Cc: | Ticket locked: | no |
Description
Steps to Reproduce:
- Start a Video from your recordings
- Press "V" for PiP.
- switch to TV
- Go back to Video
Result: Video starts from last bookmark, or if there is none, from the beginning. Also Pausing is not possible with PiP functionality, but that maybe a feature.
Attachments
Change History
comment:1 Changed 3 years ago by gnome42
- Owner changed from ijr to gnome42
- Status changed from new to accepted
- Version changed from unknown to head
- Component changed from MythTV - General to MythTV - Video Playback
- Milestone changed from 0.23 to 0.22
comment:2 Changed 3 years ago by shane
(In [20777]) Refs #6681. Fix restoring of file position after PiP/PBP Swap.
Fix a race setting the fftime variable by moving SetPlaying?(true) after fftime is initially set in NVP::StartPlaying?().
There is still a known problem with racing with the fastforward to the initial bookmark. Mitigate that in a separate patch.
comment:3 Changed 3 years ago by gnome42
- Status changed from accepted to started
- Type changed from defect to patch
The attached patch further mitigates the race condition on fftime when a bookmark is set and swapping PiPs?/PBPs.
It has been working well here but is a bit risky due to being in the main NVP::StartPlaying?() path. So, it needs lengthy testing before committing.
comment:4 Changed 2 years ago by stuarta
- Milestone changed from 0.22 to 0.24
Bumping open 0.22 milestone tickets to 0.24
comment:5 Changed 22 months ago by robertm
- Status changed from started to infoneeded
Not sure if this is still relevant after the MythUI OSD conversion. Can we get a test against current trunk? If still present, old patch is undoubtedly no longer applicable.
comment:6 Changed 21 months ago by stuartm
- Status changed from infoneeded to closed
- Resolution set to Unverified
Shane if you happen to read this and think the patch should still apply then please re-open with an updated patch.
comment:7 Changed 21 months ago by stuartm
- Version changed from head to Unspecified
- Milestone changed from 0.24 to unknown
