libmythdvdnav defects

[Erik Hovland <erik@…>]

1. Close a resource leak in an error path.
2. Use parens to guarantee the correct operator precedence.
3. Missing curly braces causes a lock to stay locked in an error path.
4. An array is indexed incorrectly opening the possibility of indexing out of bounds.

[Erik Hovland <erik@…>]

Close leak in error path

[Erik Hovland <erik@…>]

Use parens to guarantee precedence

[Erik Hovland <erik@…>]

Use curly braces to unlock mutex in error path

[Erik Hovland <erik@…>]

Index at i-1 to prevent overrun of the array.

[paulh]

(In [21716]) Fix a leak after error. Refs #6997.

[paulh]

(In [21717]) Fix a leak after error. Refs #6997.

[paulh]

(In [21718]) Add missing curly braces. Refs #6997.

[paulh]

Erik, have you verified No. 4 is correct? I can see there is something wrong since the fwda[] array has only 19 members but are you sure your fix is correct? Also shouldn't the same be done for the bwda[] array in the next else block?

[Erik Hovland <erik@…>]

Sadly, the code base is too large and my brain is too feeble to be really sure that this one is correct. But let me see...This change is not yet tested by me. Sorry. Feel free to close the ticket and mention that the patch is rejected. I will get it tested and resubmit if it still works.

Note that the mplayerhq folk have removed this code entirely from their tree. So it is likely that it is never used.

[skamithi]

fix typo in searching.c , after the major upgrade about 5 months ago, i made a type in the for loop statement.

[skamithi]

(In [21738]) Closes #6997. fix typo in searching.c that may cause an overrun. detected by Erik Hovland.