Ticket #7322 (closed defect: fixed)
Opened 2 years ago
Last modified 2 years ago
JumpPoints dont work in mythvideo gallery view or during gallery view playback
| Reported by: | oobe.trouble@… | Owned by: | awithers |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.23 |
| Component: | Plugin - MythVideo | Version: | 0.22-fixes |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
to reproduce switch to gallery view then go into a few folders and press a jump point keybinding i.e main menu or recordings
it will just move you up one directory this also happens during video playback if using gallery view.
can be reproduced in trunk and release-0-22-fixes
Attachments
-
mythvideo_jumppoints.patch
(490 bytes) -
added by Jim Stichnoth <stichnot@…> 2 years ago.
Change History
comment:1 Changed 2 years ago by Jim Stichnoth <stichnot@…>
Such a minuscule patch, such a huge delta WAF...
comment:2 Changed 2 years ago by anonymous
wow thanks heaps Jim Stichnoth I applied it to 22-fixes works cleanly and really well you made my day been waiting for someone to fix this .
comment:3 Changed 2 years ago by stuarta
- Owner changed from ijr to awithers
- Version changed from unknown to 0.22-fixes
- Component changed from MythTV - General to Plugin - MythVideo
- Milestone changed from unknown to 0.23
comment:4 Changed 2 years ago by Jim Stichnoth <stichnot@…>
Sorry -- in my excitement and haste I forgot to untabify the patch. I won't bother resubmitting since it's only a one-line patch.
I got to learn how JumpPoints? are implemented. Apparently an escape-key event is synthesized and continually propagated until the main menu is reached, and then the jump point is executed. This requires cooperation from the escape-key handler of each component/screen, which is supposed to check whether we are trying to exit out to the main menu. Without this patch, MythVideo? isn't doing that check, so if you're at a screen that takes more than one escape key to exit out of MythVideo?, JumpPoint? processing gets messed up.
comment:5 Changed 2 years ago by stuartm
The implementation of jumppoints could be vastly improved, generating keypresses is sub-optimal. With mythui we can instead just iterate down the stacks closing screens until we reach the main menu.
comment:6 Changed 2 years ago by robertm
- Status changed from new to closed
- Resolution set to fixed
(In [23085]) Fixes #7322. Allow MythVideo? views with a directory-style hierarchy to respond properly to JumpPoint? actions. Patch is a workaround until JumpPoints? are reworked in the future. Thanks to Jim Stichnoth for the patch.
