Ticket #746 (closed patch: invalid)
Opened 6 years ago
Last modified 6 years ago
Visualisers look bad when VisualNode's length is < 512
| Reported by: | eskil <myth@…> | Owned by: | danielk |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.20 |
| Component: | mythmusic | Version: | head |
| Severity: | low | Keywords: | |
| Cc: | Ticket locked: | no |
Description
I honestly don't know if this is a bug or a problem with the audio streams from various shoutcast streams.
The end result is, that eg. the StereoScope and MonoScope visualisers only visualise on a 1/4th of their line, the rest is just flatline.
I traced it down to the VisualNode passed from AudioOutput having a length of 128, where most of the visualisers expect 512. BumpScope? seemed to work around it, but the rest looked pretty bad.
I'll attach a sample file (from SomaFM shoutcast, it might playback with strange noises every 1/2 second because of meta info) and a patch. The patch fixes it in two ways
- it makes StereoScope, MonoScope and Goom work by duplicating bytes, just like BumpScope
- make MainVisual: :add also do the replication and do the linear smoothening
Attachments
-
somafm.mp3
(128.0 KB) -
added by eskil <myth@…> 6 years ago.
- sample mp3 stream from www.somafm.org
-
visualisers.patch
(5.2 KB) -
added by eskil <myth@…> 6 years ago.
- patch for visualisers
Change History
Changed 6 years ago by eskil <myth@…>
-
attachment
somafm.mp3
added
comment:1 Changed 6 years ago by danielk
- Owner changed from ijr to danielk
- Version set to head
- Milestone set to 0.20
comment:2 Changed 6 years ago by danielk
- Status changed from new to closed
- Resolution set to invalid
Eskil, this doesn't seem to improve the situation any here.
Maybe you could look at this again?
sample mp3 stream from www.somafm.org