Upcoming recordings list jumps when something changed

[prefect47@…]

On the "upcoming recordings" screen, when I change one item by for example setting an override like "don't record", the list will move so that the most currently selected item ends up at the bottom of the displayed items. Example: list shows items 10-15 of a list of 25. I change item 11 to "don't record" and move to item 9 (items 9-14 showing) before the change propagates to the UI. The list will now switch to showing items 3-9, with focus on 9 at the bottom.

The display was set to "show important" but I don't think that matters. The Terra theme was used.

[prefect47@…]

Seems to happen in watch recordings list as well, at least on the MythCenter? theme.

Also, when deleting the last remaining episode of a show, it jumps to the "All recordings" group with focus set on the newest recording. 0.21 moved focus to the show after and the first recording there.

[stuartm]

There's no entirely correct and complete fix for this which could be ready for 0.24 and I'm loathe to add specific hacks.

The main part of fix would be not to rebuild the entire list each time, that's extremely inefficient and we've already moved away from that in other places. We need to add the following new events SCHEDULE_ADDED_PROGRAMS, SCHEDULE_DELETED_PROGRAMS and SCHEDULE_UPDATED_PROGRAMS which permit incremental changes to the list without starting from scratch. This would greatly improve UI response too.

We also need a generic method in MythUIButtonList of remembering positions, something that works equally well for all list layouts, selection and wrap styles. This much might be possibly achieved for 0.24 and would mitigate the problem, though probably not eliminate it.

[stuartm]

This bug is too trivial to demand attention for 0.24 at this stage and the proper fix is more complicated than it first seems.

[stuartm]

Sadly I didn't get to this for 0.25 and the fix is too invasive to go in during the feature freeze.