Modify

Ticket #7592 (closed defect: fixed)

You must read the TicketHowTo before creating a new ticket or commenting on an existing ticket.

Opened 2 years ago

Last modified 20 months ago

ical link broken on Upcoming page on mythweb

Reported by: Paul <paul@…> Owned by: kormoc
Priority: minor Milestone: unknown
Component: Plugin - MythWeb Version: 0.22
Severity: medium Keywords:
Cc: Ticket locked: no

Description

 http://mythbox/mythweb/ical/mythweb/tv/upcoming?skip_deactivated&

Warning at /var/www/html/mythweb/modules/_shared/tmpl/_errors/unknown_module.php, line 23: require(modules/_shared/tmpl/ical/header.php) [function.require]: failed to open stream: No such file or directory

Fatal error: require() [function.require]: Failed opening required 'modules/_shared/tmpl/ical/header.php' (include_path='.:/usr/share/pear:/usr/share/php') in /var/www/html/mythweb/modules/_shared/tmpl/_errors/unknown_module.php on line 23

Attachments

ical_link.patch Download (649 bytes) - added by Nijn <info@…> 2 years ago.
proposed patch
upcoming_recordings_ical_link.diff Download (583 bytes) - added by nickj-fox@… 2 years ago.
ical link fix

Change History

Changed 2 years ago by Nijn <info@…>

proposed patch

comment:1 Changed 2 years ago by Nijn <info@…>

The ical link is wrong. it uses $_SERVERREQUEST_URI? but that already includes the root. Not sure if there is already a constant for that, but if not here is my proposed fix.

comment:2 Changed 2 years ago by nickj-fox@…

I have a diff for this that is simpler on the code side and might be easy to have implemented. I have tested that this works on my local machines.

Changed 2 years ago by nickj-fox@…

ical link fix

comment:3 Changed 2 years ago by Marc Randolph <mrand@…>

Bug #7948 (with patch) is for similar problem, but for rss link

comment:4 Changed 20 months ago by kormoc

  • Status changed from new to closed
  • Resolution set to fixed

(In [25083]) Fixes #7948, Fixes #7592, this modified the default REQUEST_URI to handle the root prefix automagically.

View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.