Ticket #7781 (closed enhancement: fixed)
Opened 2 years ago
Last modified 2 years ago
Rename inactive state to unselected. Add new inactive state
| Reported by: | jppoet@… | Owned by: | stuartm |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.23 |
| Component: | MythTV - User Interface Library | Version: | unknown |
| Severity: | low | Keywords: | |
| Cc: | Ticket locked: | no |
Description
Currently the opposite of selected is inactive, and there is no opposite of active.
This patch makes inactive the opposite of active, and adds an unselected state.
If a theme does not provide a inactive state, the active state will be used.
Patches are also provided to rename the inactive state to unselected in "official" themes.
Attachments
Change History
comment:2 Changed 2 years ago by stuartm
- Status changed from assigned to accepted
- Milestone changed from unknown to 0.23
WARNING: This patch requires themers to make changes to existing themes. It doesn't seem like a good idea to commit it this close to a release or two days before the theming competition deadline but better now when we have half a dozen themes, than in 4 months when we have 3 times that number.
comment:3 Changed 2 years ago by jppoet@…
Per discussion with Stuart, changed the state names: selected -> selectedactive inactive -> selectedinactive Add inactive for unfocused/unselected
Changed 2 years ago by jppoet@…
- Attachment MythUI-unselected-core-themes-v2.patch added
Core themes update
Changed 2 years ago by jppoet@…
- Attachment MythUI-unselected-aux-themes-v2.patch added
aux themes update
comment:4 Changed 2 years ago by jppoet@…
Updated for current trunk
Changed 2 years ago by stuartm
- Attachment selectedinactive-v3.sh added
Version which includes spinboxes
comment:5 Changed 2 years ago by stuartm
- Status changed from accepted to closed
- Resolution set to fixed
(In [23443]) Rename the button states in the buttonlist to make room for a fourth which represents the unfocused and unselected status, which had been notably missing. This is a disruptive change requiring all themes to be updated, a script has been provided to automate this in #7781. If a theme lacks the new state it will fall back to the old behaviour. Closes #7781
