Ticket #7844 (closed Patch - Bug Fix: fixed)
Opened 2 years ago
Last modified 8 months ago
Fix mythsocketthread log spam for non-pipe select (windows)
| Reported by: | Jeff Lu <jll544@…> | Owned by: | beirdo |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.25 |
| Component: | Ports - Windows | Version: | Master Head |
| Severity: | low | Keywords: | win32 socket |
| Cc: | Ticket locked: | no |
Description
Attached patch fixes a nuisance bug that generates continuous "select returned error" messages when VB_SOCKET logging is turned on. fd_set needs to be reset between calls to select(), so the "while (!rval)" loop and redundant wait need to go.
Attachments
Change History
comment:1 Changed 2 years ago by robertm
- Owner changed from ijr to nigel
- Component changed from MythTV - General to Ports - Windows
comment:2 Changed 22 months ago by robertm
- Owner changed from nigel to markk
- Status changed from new to assigned
comment:3 Changed 21 months ago by markk
- Status changed from assigned to accepted
- Milestone changed from unknown to 0.25
comment:4 Changed 10 months ago by stuartm
- Version changed from head to Trunk Head
- Type changed from patch to Patch - Bug Fix
This one seems pretty simple to review for anyone familiar with the socket code. I'm not sure it's specific to Windows either.
comment:5 Changed 8 months ago by Github
- Status changed from accepted to closed
- Resolution set to fixed
Fix spamming non-pipe select
It is necessary to reset the contents of rfds and efds both every time before running select. As this was missing from the loop, unexpected breakage occurred. Also, don't say we've received data if the rval <= 0 (i.e. no results or an error).
This is inspired by the patch in #7844. Closes #7844.
Branch: master Changeset: ea364b3b2be961bb0949381a0c1647ab9b35763e
