Opened 14 years ago
Closed 12 years ago
Last modified 10 years ago
#7994 closed Developer Task (Fixed)
Clear the bookmark at the end of playback
Reported by: | Owned by: | Jim Stichnoth | |
---|---|---|---|
Priority: | minor | Milestone: | 0.26 |
Component: | MythTV - General | Version: | Master Head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
When exiting playback, normally the bookmark is set. However, if playback exits near the end of the recording/video, the bookmark is not set, causing inconsistent behavior next time the recording/video is played. This is because when exiting in the middle of the program, it always resumes from the same point, but when exiting at the end, the resume point depends on whether a bookmark was previously set.
It would be more consistent to always clear the bookmark when playback exits near the end. This patch does that.
Attachments (11)
Change History (27)
Changed 14 years ago by
Attachment: | clear_bookmark_at_end.patch added |
---|
Changed 14 years ago by
Attachment: | clear_bookmark_at_end_2.patch added |
---|
comment:1 Changed 14 years ago by
I was reminded of the frontend setting that controls whether bookmarks are saved on exit: either always, never, or after a prompt. We shouldn't mess with bookmarks unless that setting is "always". The new patch fixes this, and also tries to clean up the bookmark handling for all the calls to TV::PrepareToExitPlayer?().
Changed 14 years ago by
Attachment: | clear_bookmark_at_end_3.patch added |
---|
Changed 14 years ago by
Attachment: | clear_bookmark_at_end_4.patch added |
---|
comment:3 Changed 14 years ago by
Updated to clear_bookmark_at_end_4.patch after the ProgramInfo? refactoring.
Changed 14 years ago by
Attachment: | clear_bookmark_at_end_5.patch added |
---|
comment:4 Changed 14 years ago by
Updated to clear_bookmark_at_end_5.patch to fix a minor problem. I have some .mkv files under MythVideo? for which IsNearEnd?() finds that framesRead > totalFrames, which causes the wrong result to be returned.
comment:5 Changed 14 years ago by
Note that clear_bookmark_at_end_5.patch is a combination of clear_bookmark_at_end_4.patch and the patch from #8527.
Changed 14 years ago by
Attachment: | clear_bookmark_at_end_6.patch added |
---|
comment:6 Changed 14 years ago by
Updated to clear_bookmark_at_end_6.patch after the libmythui-osd branch merge. The patch from #8527 is also needed to make this work properly for videos (as opposed to recordings).
Changed 14 years ago by
Attachment: | clear_bookmark_at_end_8.patch added |
---|
comment:7 Changed 14 years ago by
Updated to version 8 (must have forgotten to upload version 7) after various trunk updates, notably the NVP renaming.
comment:8 Changed 14 years ago by
Owner: | changed from Isaac Richards to sphery |
---|---|
Status: | new → assigned |
Changed 13 years ago by
Attachment: | clear_bookmark_at_end_10.patch added |
---|
Changed 13 years ago by
Attachment: | clear_bookmark_at_end_11.patch added |
---|
Changed 13 years ago by
Attachment: | clear_bookmark_at_end_14.patch added |
---|
Adds the logic regarding "realTotalFrames" to IsNearEnd?(). This is probably worthy of a separate bug report, but it's hard to see the impact without this whole patch.
comment:9 Changed 12 years ago by
Owner: | changed from sphery to Jim Stichnoth |
---|---|
Type: | patch → Developer Task |
comment:10 Changed 12 years ago by
Milestone: | unknown → 0.26 |
---|---|
Version: | unknown → Master Head |
comment:13 Changed 12 years ago by
Resolution: | → Fixed |
---|---|
Status: | assigned → closed |
Use this instead of clear_bookmark_at_end.patch