Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower reponse.
Opened 3 years ago
Closed 14 months ago
#7994 closed Developer Task (Fixed)
Clear the bookmark at the end of playback
| Reported by: | Jim Stichnoth <stichnot@…> | Owned by: | stichnot |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.26 |
| Component: | MythTV - General | Version: | Master Head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
When exiting playback, normally the bookmark is set. However, if playback exits near the end of the recording/video, the bookmark is not set, causing inconsistent behavior next time the recording/video is played. This is because when exiting in the middle of the program, it always resumes from the same point, but when exiting at the end, the resume point depends on whether a bookmark was previously set.
It would be more consistent to always clear the bookmark when playback exits near the end. This patch does that.
Attachments (11)
Change History (24)
Changed 3 years ago by Jim Stichnoth <stichnot@…>
Changed 3 years ago by Jim Stichnoth <stichnot@…>
comment:1 Changed 3 years ago by Jim Stichnoth <stichnot@…>
I was reminded of the frontend setting that controls whether bookmarks are saved on exit: either always, never, or after a prompt. We shouldn't mess with bookmarks unless that setting is "always". The new patch fixes this, and also tries to clean up the bookmark handling for all the calls to TV::PrepareToExitPlayer?().
Changed 3 years ago by Jim Stichnoth <stichnot@…>
comment:2 Changed 3 years ago by Jim Stichnoth <stichnot@…>
Updated patch against a recent version of trunk.
Changed 3 years ago by Jim Stichnoth <stichnot@…>
comment:3 Changed 3 years ago by Jim Stichnoth <stichnot@…>
Updated to clear_bookmark_at_end_4.patch after the ProgramInfo? refactoring.
Changed 3 years ago by Jim Stichnoth <stichnot@…>
comment:4 Changed 3 years ago by Jim Stichnoth <stichnot@…>
Updated to clear_bookmark_at_end_5.patch to fix a minor problem. I have some .mkv files under MythVideo? for which IsNearEnd?() finds that framesRead > totalFrames, which causes the wrong result to be returned.
comment:5 Changed 3 years ago by Jim Stichnoth <stichnot@…>
Note that clear_bookmark_at_end_5.patch is a combination of clear_bookmark_at_end_4.patch and the patch from #8527.
Changed 3 years ago by Jim Stichnoth <stichnot@…>
comment:6 Changed 3 years ago by Jim Stichnoth <stichnot@…>
Updated to clear_bookmark_at_end_6.patch after the libmythui-osd branch merge. The patch from #8527 is also needed to make this work properly for videos (as opposed to recordings).
Changed 3 years ago by Jim Stichnoth <stichnot@…>
comment:7 Changed 3 years ago by Jim Stichnoth <stichnot@…>
Updated to version 8 (must have forgotten to upload version 7) after various trunk updates, notably the NVP renaming.
comment:8 Changed 3 years ago by robertm
- Owner changed from ijr to mdean
- Status changed from new to assigned
Changed 3 years ago by Jim Stichnoth <stichnot@…>
Changed 3 years ago by Jim Stichnoth <stichnot@…>
Changed 2 years ago by Jim Stichnoth <stichnot@…>
Adds the logic regarding "realTotalFrames" to IsNearEnd?(). This is probably worthy of a separate bug report, but it's hard to see the impact without this whole patch.
comment:9 Changed 16 months ago by wagnerrp
- Owner changed from mdean to stichnot
- Type changed from patch to Developer Task
Changed 16 months ago by stichnot
Updated to latest master.
comment:10 Changed 16 months ago by stichnot
- Milestone changed from unknown to 0.26
- Version changed from unknown to Master Head
comment:11 Changed 14 months ago by Jim Stichnoth <jstichnoth@…>
comment:12 Changed 14 months ago by Jim Stichnoth <jstichnoth@…>
comment:13 Changed 14 months ago by stichnot
- Resolution set to Fixed
- Status changed from assigned to closed
Use this instead of clear_bookmark_at_end.patch