Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 3 years ago

Last modified 9 months ago

#8011 accepted Patch - Feature

watchlist showing oldest and more group summary data

Reported by: nzhook Owned by: stuartm
Priority: minor Milestone: 0.27
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Attached is one patch that provides two separate things (different sections in the patch so only one can be applied if required)

  • When in the Watch Recordings screens and selecting group, the summary displays 'there are X recordings in this display group', however it does not say the total amount of time or the total disk space. The first part of this patch calculates these two figures and assigns them to the standard template vars (lentime, lenmins, filesize, and filesize_str)
  • The watchlist currently displays the newest recordings, normally however the oldest are more important as they maybe deleted first or should be watched in order to keep in sync with what is going on. The second part of this patch adds the oldest recording to the watchlist.

Note: the second part also includes some additional debug info for doing a grep in the debug output to find the watchlist info. While its not required for the patch it will be useful when debugging any issues that occur when looking at the watchlist.

This patch applies was last updated using SVN #23010, but applies cleanly to SVN #23421 (patch from this revision)

Attachments (2)

mythtv.grouptotals.patch (6.8 KB) - added by James Hook <mythtv.hook@…> 3 years ago.
Patch
8011_v1.diff (2.7 KB) - added by paulh 3 years ago.
Updated following the PI refactor

Download all attachments as: .zip

Change History (11)

Changed 3 years ago by James Hook <mythtv.hook@…>

Patch

comment:1 Changed 3 years ago by danielk

  • Component changed from MythTV - Recording to MythTV - General
  • Owner changed from danielk to ijr
  • Version changed from unknown to head

comment:2 Changed 3 years ago by robertm

  • Resolution set to wontfix
  • Status changed from new to closed

The space portion of this is basically accomplished by the reintroduction of the delete recordings screen, if something like this is going to be considered you might just add the "time" element to that? Personally, though, I am not a huge fan of the lack of flexibility of this stuff, it doesn't give the themers any control over how the information is presented. If you modify this to add the time stuff to delete recordings, please reopen with that patch and we can review for you.

comment:3 Changed 3 years ago by nzhook <mythtv.hook@…>

  • Resolution wontfix deleted
  • Status changed from closed to new

Sorry for taking so long to get back regarding this.

From your response I dont think you may have mis read this as something the delete recordings screen should have. Which is not really something this patch was designed to provide.

This patch provides the totals of the numbers when in the group selection, rather than the 'there are X recordings in this display group', thus giving themers more information to work with than a single line which they are unable to change. (which BTW this was a patch I created when I was creating a theme but never got the time to finish)

eg. If the user has 3 recordings in a group:

recording 1 1 hour
recording 2 2 hours
recording 3 30 minutes

when the user is on the group selection the lentime value available to the theme is set to 2 hours 30 minutes rather than being blank. It also does this with the other numeric values (such as disk space)

I use this patch on my frontend on a regular basis to see how much total time I have to watch still, eg. im a little behind on Lost, In fact this patch tells me im 4 hours behind.

The other part of the patch, is that it lists the oldest Lost episode before the most recent. I dont want to watch episode 13 of before I watch episode 11, currently however the Watch Recordings list is showing episode 13 and not episode 11, which is what the patch fixes.

comment:4 Changed 3 years ago by robertm

  • Resolution set to wontfix
  • Status changed from new to closed
  • Ticket locked set

No change to patch to add requested flexibility.

comment:5 Changed 3 years ago by robertm

  • Resolution wontfix deleted
  • Status changed from closed to new
  • Ticket locked unset

Re-opening, we'd like to work with you to make some tweaks to this so that everyone is happy.

Changed 3 years ago by paulh

Updated following the PI refactor

comment:6 Changed 3 years ago by paulh

Updated the size and length part of the patch after the PI changes and adds the required text area to MythCenter?-wide.

comment:7 Changed 3 years ago by robertm

  • Owner changed from ijr to paulh
  • Status changed from new to assigned

comment:8 Changed 16 months ago by stuartm

  • Milestone changed from unknown to 0.26
  • Owner changed from paulh to stuartm
  • Status changed from assigned to accepted
  • Type changed from enhancement to Patch - Feature
  • Version changed from head to Master Head

I always like exposing more data in the UI, however it would be better not to re-use existing textareas, there are more interesting things possible if group/recording info can be displayed simultaneously or with a different layout.

This would also mean changing the existing code so that group name isn't inserted into 'title' and group info isn't in 'description'.

With 'depends' and <group> we can hide those strings if desired when the recording list is selected and still allow the space to be re-used.

comment:9 Changed 9 months ago by kenni

  • Milestone changed from 0.26 to 0.27

Add Comment

Modify Ticket

Action
as accepted .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.