Ticket #8121 (closed patch: fixed)
Opened 2 years ago
Last modified 21 months ago
Build fixes for windows port
| Reported by: | Jeff Lu <jll544@…> | Owned by: | nigel |
|---|---|---|---|
| Priority: | minor | Milestone: | unknown |
| Component: | Ports - Windows | Version: | head |
| Severity: | medium | Keywords: | win32 |
| Cc: | Ticket locked: | yes |
Description
Attached are a pair of small patches to build r23640 on Windows:
qtdbus_win.patch: Extend QtDBus check from [23560] to verify that QtDBus lib exists. On Windows, Nokia distributes the headers even though the lib isn't built.
setuid_win.patch: On Windows, disable the MBE --user option from [23521]. MinGW doesn't have pwd.h, and AFAIK there isn't a direct analogue of setuid on Windows anyway.
Attachments
Change History
comment:1 Changed 2 years ago by anonymous
Thanks for this! Been driving me mad this one!
Do you know when this is scheduled for inclusion in SVN?
Changed 23 months ago by Jeff Lu <jll544@…>
-
attachment
8121-23521_setuid_win.2.patch
added
Updated for [23835]
comment:3 Changed 23 months ago by Jeff Lu <jll544@…>
Two additional patches attached:
mythsystem.patch: Apply result code changes from [23575] to Windows. Returns embedded in Windows code prevented mythtv-setup screens from being drawn.
fullscreen.patch: Change order of operations after [23765] to work around Qt bug. On Windows, Qt does not honor fullscreen mode if setWindowState(Qt::WindowFullScreen?) is called before setWindowFlags(Qt::FramelessWindowHint?). Tested this change on my Fedora and Ubuntu boxes and observed no ill effects for Linux.
comment:4 Changed 22 months ago by jamesjt@…
I'm still having difficulty getting 0.23-fixes to compile. I used .../release-0-23-fixes/.../MythInstaller?.bat to get the latest script, but neither
win32-packager.pl -v -k -b -r HEAD
nor
win32-packager.pl -v -k -b (-l)
will compile at this point.
I manually applied the changes from 8121-23521_setuid_win.2.patch in order to try to get it to compile, and now here's the error I'm stuck with:
make[2]: * [main.o] Error 1 make[2]: Leaving directory `/C/mythtv/mythtv/programs/mythbackend' make[1]: * [sub-mythbackend-make_default] Error 2 make[1]: Leaving directory `/C/mythtv/mythtv/programs' make: * [sub-programs-make_default-ordered] Error 2 EFFECT FAILED (newer -> shell): mtime of file (C:/mythtv/mythtv/programs/mythbackend/mythbackend.exe) should be greater than file (C:/mythtv/mythtv/last_build.txt).
Could someone point me in the right direction, please?
comment:5 Changed 22 months ago by robertm
- Ticket locked set
Discussion belongs on mailing lists, please read the ticket howto.
comment:6 Changed 21 months ago by mdean
comment:7 Changed 21 months ago by mdean
comment:8 Changed 21 months ago by mdean
comment:9 Changed 21 months ago by mdean
(In [24482]) Compilation fix for MS Windows. Do not allow the --user option on Windows. Refs #8121.
This is an updated version of the patch submitted by Jeff Lu, taking into account changes in [24030]. I can not test the fix on Windows, and since it's not the same patch submitted by Jeff, any breakage is due to me. So if it doesn't work, please let me know with a message to the mailing list.
comment:10 Changed 21 months ago by mdean
I've applied patches for all the (currently) submitted issues, except 8121-23560_qtdbus_win.patch , which I'll leave for someone more knowledgeable than I to review.
comment:11 Changed 21 months ago by janne
comment:12 Changed 21 months ago by mdean
comment:13 Changed 21 months ago by mdean
comment:14 Changed 21 months ago by mdean
comment:15 Changed 21 months ago by janne
- Status changed from assigned to closed
- Resolution set to fixed
