Ticket #8217 (closed Patch - Bug Fix: Fixed)
Opened 3 years ago
Last modified 7 weeks ago
programs from xmltv source around DST change are off by 2h
| Reported by: | Andreas Oeldenberger <Andreas.Oeldenberger@…> | Owned by: | mdean |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.27 |
| Component: | MythTV - Mythfilldatabase | Version: | Master Head |
| Severity: | medium | Keywords: | DST UTC XMLTV QT |
| Cc: | Ticket locked: | no |
Description
fromXMLTVDate is using QtDateTime::addSecs to calculate UTC time in Auto mode. Now if addSecs hits a DST change it will honor that an mess up our calculation.
To stop addSecs from doing this the TimeSpec? has to be set to Qt::UTC.
See attached path for a quick fix.
PS: Perhaps its time do drop MythUTCToLocal and use correct TimeSpecs? and QtDateTime::toLocalTime?
Attachments
Change History
Changed 3 years ago by Andreas Oeldenberger <Andreas.Oeldenberger@…>
- Attachment addSecsDST.patch added
comment:1 Changed 3 years ago by mdean
- Owner changed from stuartm to mdean
- Status changed from new to accepted
comment:2 follow-up: ↓ 3 Changed 15 months ago by stuartm
- Version changed from head to Master Head
- Type changed from patch to Patch - Bug Fix
Where does this fit with the switch to using GMT internally?
comment:3 in reply to: ↑ 2 Changed 15 months ago by Andreas Oeldenberger <andreas.oeldenberger@…>
Replying to stuartm:
Where does this fit with the switch to using GMT internally?
uhm.... wow!
Took a quick look at utc changes... should still be the same.
Note: I stopped using xmltv over a year ago. 2nd Note: You may only experience the bug for programs starting/stopping during the hour of DST Change as that's where QtDateTime::addSecs is doing it's magic.
comment:4 Changed 7 weeks ago by dekarl
- Status changed from accepted to closed
- Resolution set to Fixed
- Milestone changed from unknown to 0.27
Should be fixed in [ff5ab27842c522f9e054876a8eb69a51b8c86a2e] in master by removing the code in question.
