Modify

Ticket #8334 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

libavcodec/mpeg12.c fails to compile on MacOS X

Reported by: anonymous Owned by: janne
Priority: minor Milestone: 0.24
Component: Ports - OSX Version: Master Head
Severity: high Keywords:
Cc: Ticket locked: no

Description

cd libmythui/ && /usr/bin/make -f Makefile mpeg12.c: In function ‘mpeg_decode_user_data’: mpeg12.c:2315: error: ‘uint’ undeclared (first use in this function) mpeg12.c:2315: error: (Each undeclared identifier is reported only once mpeg12.c:2315: error: for each function it appears in.) mpeg12.c:2315: error: expected ‘;’ before ‘cc_count’ mpeg12.c:2316: error: expected ‘;’ before ‘cc_bits’ mpeg12.c:2317: error: expected ‘;’ before ‘cc_bytes’ mpeg12.c:2320: error: ‘cc_bytes’ undeclared (first use in this function) mpeg12.c:2326: error: ‘cc_count’ undeclared (first use in this function) make[2]: * [mpeg12.o] Error 1 make[1]: * [sub-libavcodec-make_default] Error 2 make[1]: * Waiting for unfinished jobs.... make[2]: Nothing to be done for `first'. make: * [sub-libs-make_default-ordered] Error 2 [osx-pkg] Failed system call: " /usr/bin/make -j3 " with error code 2

uint isn't defined. These variables really should be uint8_t.

Attachments

mythosx.diff (794 bytes) - added by dougt@… 3 years ago.
patch to libs/libavcodec/mpeg12.c

Change History

Changed 3 years ago by dougt@…

patch to libs/libavcodec/mpeg12.c

comment:1 follow-up: ↓ 2 Changed 3 years ago by robertm

  • Status changed from new to infoneeded_new

This is an upstream library that a) we won't modify any more than we have locally and b) definitely compiles on OS X.

Are you doing anything exotic in attempting to build? Are you using the build script? Have you made any modifications to it? What version of OS X? What architecture?

comment:2 in reply to: ↑ 1 Changed 3 years ago by dougt@…

Replying to robertm:

This is an upstream library that a) we won't modify any more than we have locally and b) definitely compiles on OS X.

Are you doing anything exotic in attempting to build? Are you using the build script? Have you made any modifications to it? What version of OS X? What architecture?

10.6.3, xcode up to date. No local changes to the source.

I am using the osx-packager tool:

perl osx-packager.pl -plugins mythvideo,mythweather

nothing else very special.

comment:3 Changed 3 years ago by robertm

  • Status changed from infoneeded_new to new

This build failure introduced by r24059. Daniel, this patch seems fine but since it's your code you would know better.

comment:4 Changed 3 years ago by robertm

  • Owner changed from nigel to danielk
  • Status changed from new to assigned

comment:5 Changed 3 years ago by janne

  • Owner changed from danielk to janne
  • Status changed from assigned to accepted
  • Milestone changed from unknown to 0.24

comment:6 Changed 3 years ago by janne

  • Status changed from accepted to closed
  • Resolution set to fixed

(In [24093]) replaces uint with unsigned int in libs/libav*, Fixes #8334

View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.