Vuvuzela filter

[jyavenard]

Watching the football worlcup? Annoyed with those horns ?

this patch will help.

It is implemented by filtering the frequencies 233, 466, 932 and 1864Hz using a band-stop filter (notch filter)

Was provided the info from:  http://www.afterdawn.com/news/article.cfm/2010/06/14/vuvuzela_buzz_ruining_your_world_cup_get_rid_of_it

It is not perfect, but once active, you can finally hear people cheering..

May commit it for convenience, but I feel the bi-quad filters parameters could be improved. If people are willing to tweak a bit, this is done in the file mythtv/libs/libmyth/audiooutpututil.cpp in void AudioOutputUtil::notch_update()

By the way, the methods provided in the above link, don't give IMHO as good results.

How to use it: Go to the settings -> general in the audio section. Activate Advanced Audio and check the Vuvuzela box. Validate all pages to the end.

Now when watching a game, press menu, you'll see an entry "Toggle Vuvuzela Filter"

The vuvuzela filter is disabled by default, and needs to be manually enabled each time

[jyavenard]

Vuvuzela filter

[bauner]

can you pls post your patch for recent 0.23 fixes also? I will try it, but in 0.23 I don't find some files that you patch.

I'm not firm with c++ so I can't do the changes by myself

[wagnerrp]

Please keep requests and discussion on the mailing lists.

[jyavenard]

New version supports AC3 and DTS audio (and any format for that matter).

Attached version for trunk, you'll need SVN trunk >= r25124, as there were two bugs preventing it to work properly.

Attached version for 0.23-fixes

[jyavenard]

0.23-fixes version

[MarcT <myrdhn@…>]

trunk 25124 version does not actually apply cleanly.

Hunk 3 of audiooutputbase.cpp fails because the section of code in trunk is

settings.samplerate == source_samplerate && settings.use_passthru == passthru && lneeds_upmix == needs_upmix && lreenc == reenc && lsource_channels == source_channels && lneeds_downmix == needs_downmix;

The patch is looking for

settings.samplerate == source_samplerate && settings.use_passthru == passthru && lneeds_upmix == needs_upmix && lreenc == reenc && lneeds_downmix == needs_downmix;

[jyavenard]

Vuvuzela filter patch for trunk

[jyavenard]

update trunk patch..

[jyavenard]

Updated to remove weight sum with original signal

[jyavenard]

I updated the patch, removing 465 and 235Hz frequencies only. Also made the filter more aggressive. I'm quite pleased with the result now... will give it a rest for now.

Will find why the 0.23-fixes patch doesn't work sometimes with AC3 5.1 audio and update with the new filter paramaters

[Jonathan Martens <jonathan@…>]

Replying to jyavenard:

update trunk patch..

Not sure if that is intended (or desired) but this patch seems to make some white space changes to mythtv/libs/libmythtv/tv_play.cpp which are irrelevant to the changes in this bug.

[jyavenard]

It aligns all the strings together, the way they were aligned before... Feel free to revert those changes before applying the patch, who knows, it may compile faster :P

[jyavenard]

Updated version for 0.23-fixes

[jyavenard]

The new version fixes issues with multi-channels audio and AC3 tracks.

It relies on using 0.23-fixes r25135 and greater as the bug was in the upstream code and got fixed.

[jyavenard]

Patch for SVN > r25136

[jyavenard]

Updated version for trunk 25165

[robertm]

Jean-Yves,

Just infoneeding this as I work through tickets since I think you mentioned wanting to close it post-world-cup. Feel free to undo that if I misunderstood.

[jyavenard]

World cup is over, and hopefully so are the vuvuzelas.