Opened 14 years ago
Closed 11 years ago
#8668 closed Patch - Feature (Fixed)
compiling flac on windows (as a requirement for mythmusic)
Reported by: | Owned by: | ||
---|---|---|---|
Priority: | minor | Milestone: | unknown |
Component: | Ports - Windows | Version: | Master Head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
Although MythMusic also needs libcdaudio (which is a hard on on windows), it also requires flac.
To compile flac to errors during compilation have to be fixed, attached patch does so. I have not been able to tie it in properly into the buildscript, but I thought I'd share it here for others/future reference.
Attachments (2)
Change History (15)
Changed 14 years ago by
Attachment: | flac.patch added |
---|
comment:1 Changed 14 years ago by
Replying to Jonathan Martens <jonathan@…>:
Although MythMusic also needs libcdaudio (which is a hard on on windows), it also requires flac.
To compile flac to errors
Oops, that should have read two errors:
In file included from stream_decoder.c:57: share/alloc.h:41:5: #error In file included from stream_decoder.c:57: share/alloc.h: In function `safe_malloc_mul_2op_': share/alloc.h:120: error: `SIZE_T_MAX' undeclared (first use in this function ) share/alloc.h:120: error: (Each undeclared identifier is reported only once share/alloc.h:120: error: for each function it appears in.) share/alloc.h: In function `safe_malloc_mul_3op_': share/alloc.h:130: error: `SIZE_T_MAX' undeclared (first use in this function ) share/alloc.h: In function `safe_malloc_mul2add_': share/alloc.h:143: error: `SIZE_T_MAX' undeclared (first use in this function ) share/alloc.h: In function `safe_realloc_mul_2op_': share/alloc.h:196: error: `SIZE_T_MAX' undeclared (first use in this function )
main.cpp: In function 'int main(int, char**)': main.cpp:75: error: 'memcmp' was not declared in this scope
The fixes in this patch are taken from the flac-dev mailinglist (SIZE_T_MAX: http://lists.xiph.org/pipermail/flac-dev/2008-August/002568.html) and the gentoo bug tracker (memcmp: http://bugs.gentoo.org/199579).
comment:2 Changed 14 years ago by
Owner: | changed from Nigel to markk |
---|---|
Status: | new → assigned |
comment:3 follow-up: 5 Changed 14 years ago by
Resolution: | → wontfix |
---|---|
Status: | assigned → closed |
Jonathan,
I think that getting MythMusic compiling on Windows is an admirable goal, but this patch in isolation can't really be applied to anything. If you'd like to work up the changes to the build script to get and install libcdaudio, and inlike this patch like we do with the Qt stuff, please reopen. Alternately, if there's a later version that incorporates these patches (as the gentoo bug *sort of* seems to indicate, we might be able to get away with using just that. I am closing this "wontfix" for now since it's missing those components, but if you decide to work up a patch, please feel free to reopen and I will test and apply.
comment:4 Changed 14 years ago by
which flac are you using? The win32-packager used to compile flac 1.2.1 just fine without any mods. If it's a problem with the headers in flac ( which this appears to be), then this should be escalated to the FLAC team.
Changed 14 years ago by
Attachment: | win32-packager.pl-flac.patch added |
---|
Patch to build get flac to compile from the win32 build script
comment:5 Changed 14 years ago by
Resolution: | wontfix |
---|---|
Status: | closed → new |
Replying to robertm:
I think that getting MythMusic compiling on Windows is an admirable goal
Thanks!
but this patch in isolation can't really be applied to anything. If you'd like to work up the changes to the build script to get and install libcdaudio, and inlike this patch like we do with the Qt stuff, please reopen.
Still need to do libcdaudio, but here is the flac part, re-opening.
comment:6 Changed 14 years ago by
Milestone: | unknown → 0.24 |
---|---|
Version: | Unspecified → Trunk Head |
comment:7 Changed 14 years ago by
Milestone: | 0.24 → 0.25 |
---|---|
Owner: | changed from markk to robertm |
Status: | new → assigned |
This isn't going to happen for .24, I'm not going to make any more such changes to the build script until after the release.
comment:9 Changed 12 years ago by
Milestone: | 0.25 → unknown |
---|
comment:10 Changed 12 years ago by
Type: | enhancement → Patch - Feature |
---|
comment:11 Changed 12 years ago by
Owner: | robertm deleted |
---|
comment:12 Changed 12 years ago by
Status: | assigned → new |
---|
comment:13 Changed 11 years ago by
Resolution: | → Fixed |
---|---|
Status: | new → closed |
Patch to make flac compile on windows