Ticket #8900 (closed patch: fixed)
Opened 3 years ago
Last modified 12 months ago
Prefer FLAC to AC3
| Reported by: | anonymous | Owned by: | robertm |
|---|---|---|---|
| Priority: | trivial | Milestone: | 0.25 |
| Component: | MythTV - General | Version: | Master Head |
| Severity: | low | Keywords: | |
| Cc: | Ticket locked: | yes |
Description
I have some MKVs with a FLAC and AC3 track. I'd like the FLAC track to be preferred. A better patch would also prefer PCM tracks to AC3.
Attachments
Change History
comment:1 Changed 3 years ago by anonymous
MKVs seem to have a concept of a default track which MythTV appears to ignore. Respecting that would work as well.
comment:2 Changed 3 years ago by robertm
- Priority changed from minor to trivial
- Status changed from new to infoneeded_new
- Severity changed from medium to low
FLAC is definitely not superior to all the other lossless audio codecs you put it above. (TrueHD, etc) Definitely can't make FLAC the "most preferred" audio track. Would accept a patch to use the default audio track from MKV, though.
comment:4 Changed 3 years ago by anonymous
Added a second patch to use the default audio track. Tested it by using mmg to edit the header of a MKV file.
comment:5 Changed 3 years ago by robertm
- Status changed from infoneeded_new to new
- Version changed from Unspecified to Trunk Head
- Milestone changed from unknown to 0.25
comment:8 Changed 3 years ago by anonymous
This more recent patch prefers TrueHD to FLAC to EAC3.
comment:9 Changed 2 years ago by robertm
- Status changed from assigned to closed
- Resolution set to Fixed
Fixed in 486d2c5.
comment:10 Changed 2 years ago by Robert McNamara
- Resolution changed from Fixed to fixed
Select the Default audio track if the container supports it.
Containers such as MKV permit one to define which audio track is primary, and using this flag means not going through the avformatdecoder guesswork we currently employ. This is courtesy an anonymous patch on #8900. I am uncomfortable with applying the part that prefers FLAC to E-AC3/DTS/AC3, though. There are a lot of people out there who encode secondary tracks to FLAC and do a straight copy of the lossy primary track. I just don't feel 100% on the idea of preferring it to other more commonplace codecs.
Fixes #8900.
Changeset: 486d2c5428c96d3f04b9f7d2646a823abf1bf1f7
