Modify ↓

Ticket #9242 (closed Patch - Bug Fix: Fixed)

Opened 3 years ago

Last modified 3 years ago

[PATCH] Windows OpenGL video playback broken

Reported by: Lawrence Rust <lvr@…> Owned by: markk
Priority: minor Milestone: 0.24.1
Component: Ports - Windows Version: Master Head
Severity: high Keywords: OpenGL windows video
Cc: Ticket locked: no

Description

On Windows, MythTV has a setting to select OpenGL as the current video renderer. Unfortunately, tv & video playback is broken on my Win32 systems (Win2k and WinXP with Nvidia GTS 2 Pro graphics) together with Wine 1.3.6 and VirtualBox? 3.2.10. The attached patch enables video on all these systems.

Attachments

win32-opengl.diff​ (589 bytes) - added by Lawrence Rust <lvr@…> 3 years ago.
OpenGL Windows video fix

Change History

Changed 3 years ago by Lawrence Rust <lvr@…>

OpenGL Windows video fix

comment:1 Changed 3 years ago by beirdo

  • Owner changed from nigel to markk
  • Status changed from new to assigned

comment:2 Changed 3 years ago by markk

see r27281

comment:3 Changed 3 years ago by markk

  • Status changed from assigned to closed
  • Resolution set to Fixed

(In [27292]) Backport r27281 from trunk to release-0-24-fixes

Don't call QGLContext::doneCurrent() in MythRenderOpenGL.

  • it should be unnecessary given that makeCurrent always checks the

correct context is current to the current thread and following the threading changes, all of our OpenGL usage should be in the same thread.

  • it breaks playback on certain Windows builds.
  • it has a sizeable performance impact on at least one Intel system.

Closes #9242

comment:4 Changed 3 years ago by kenni

  • Milestone changed from unknown to 0.24.1
View ↑

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.