Modify ↓

Ticket #9253 (closed Patch - Bug Fix: Fixed)

Opened 3 years ago

Last modified 2 years ago

Wrong file size shown in program details screen

Reported by: John Veness <John.Veness.mythtv@…> Owned by: danielk
Priority: trivial Milestone: unknown
Component: MythTV - General Version: 0.24-fixes
Severity: low Keywords: progdetails
Cc: Ticket locked: no

Description

The file size shown by pressing I twice while a program is highlighted in Watch Recordings is incorrect. It shows 0.00 GB, 1.00 GB, 2.00 GB etc., always as an integer number of GB.

I think the bug was introduced with changeset [24694], see ​http://svn.mythtv.org/trac/changeset/24694/trunk/mythtv/programs/mythfrontend/progdetails.cpp

I have made a patch which I think fixes this, against 0.24-fixes, which I submit for consideration.

Attachments

progdetails-size.patch​ (686 bytes) - added by John Veness <John.Veness.mythtv@…> 3 years ago.

Change History

Changed 3 years ago by John Veness <John.Veness.mythtv@…>

comment:1 Changed 3 years ago by robertm

  • Owner set to danielk
  • Status changed from new to assigned

comment:2 Changed 3 years ago by danielk

  • Status changed from assigned to accepted

Heh, thanks for figuring that out. Took me a second to look at the code and realize my mistake.

comment:3 Changed 2 years ago by danielk

  • Status changed from accepted to closed
  • Resolution set to Fixed

(In [27343]) Fixes #9253. Fix rounding of file size on a program details screen.

comment:4 Changed 2 years ago by John Veness <John.Veness.mythtv@…>

Can this be backported to 0.24-fixes? It's a very small patch so I hope this is OK. Sorry if it is bad etiquette to request this here.

View ↑

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.