Modify ↓

Ticket #9288 (closed Bug Report: Fixed)

Opened 2 years ago

Last modified 2 years ago

Change 24895- the toLower is the wrong place

Reported by: cpw@… Owned by: beirdo
Priority: trivial Milestone: 0.24.1
Component: Plugin - MythGallery Version: 0.24
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Hi Myth 0.24 broke mythgallery video playing for me. All my files are (unfortunately) in upper case: *.MOV mostly. The Changeset 24895 adding in mp4 and cleaning up the upper/lower stuff in the filter does one thing slightly wrong. The change does this: 

        if ((*it).toLower().contains(fi.suffix()))

However, you actually meant to toLower the file suffix, so it matches the filter contents: 

        if ((*it).contains(fi.suffix().toLower()))

I have compiled this change locally and confirm it works.

Christian

Attachments

Change History

comment:1 Changed 2 years ago by beirdo

  • Priority changed from major to trivial
  • Status changed from new to assigned
  • Milestone changed from unknown to 0.24.1

comment:2 Changed 2 years ago by beirdo

Committed in 641d6e65 for master, fe9d48e5 for fixes/0.24

comment:3 Changed 2 years ago by beirdo

  • Status changed from assigned to closed
  • Resolution set to Fixed
View ↑

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.