Ticket #9430 (closed Bug Report: fixed)
Opened 2 years ago
Last modified 23 months ago
RemoveDirectory name clash
|Reported by:||Lawrence Rust <lvr@…>||Owned by:||beirdo|
|Component:||MythTV - MythSystem||Version:||Master Head|
In commit e090e97d2e422e91c289b8728dca674ae4529efb the function RemoveDirectory? was added. Unfortunately the same name is #defined in <windows.h> to have either a W or A suffix depending on UNICODE. This causes Windows builds of MythArchive? to fail with unresolved references to RemoveDirectoryW.
A pragmatic solution is to #undef RemoveDirectory? in libs/linmyth/util,cpp just before its definition and to do the same just before the inclusion of util.h in mythplugins/mytharchive/mytharchivehelper/main.cpp and mythplugins/mytharchive/mytharchive/mythburn.cpp.
A more elegant solution would be to rename it to say MythRemoveDirectory?.
comment:1 Changed 2 years ago by beirdo
- Owner changed from paulh to beirdo
- Status changed from new to assigned
comment:2 Changed 2 years ago by beirdo
- Component changed from Plugin - MythArchive to MythTV - MythSystem
comment:3 Changed 2 years ago by beirdo
comment:4 Changed 2 years ago by beirdo
- Status changed from assigned to closed
- Resolution set to Fixed
comment:5 Changed 2 years ago by Gavin Hurlbut
- Resolution changed from Fixed to fixed
comment:6 Changed 23 months ago by wagnerrp
- Milestone changed from unknown to 0.25